Skip to content

Revert "Revert "fix some bugs in new workflow""#2099

Closed
rachmari wants to merge 5 commits intomainfrom
revert-2098-revert-2094-rachmari-update-unallowed-workflow
Closed

Revert "Revert "fix some bugs in new workflow""#2099
rachmari wants to merge 5 commits intomainfrom
revert-2098-revert-2094-rachmari-update-unallowed-workflow

Conversation

@rachmari
Copy link
Copy Markdown
Contributor

@rachmari rachmari commented Dec 15, 2020

Why:

The pull request event will run for each new push to the branch, so the push event is not necessary. I've removed the push event and the step that retrieved the pull number when the triggering event was a push.

When the check to dismiss a review runs and there are no prior reviews by github-actions[bot], the check fails in the fromJSON conditional check: https://github.com/github/docs/pull/2062/checks?check_run_id=1548110821

  • The fix is to check that a review result actually exists before getting the properties of the object.

I also added a bit more logging for the future just so we have some basic info.

Check off the following:

  • All of the tests are passing.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.

  • .github/workflows/triage-unallowed-contributions.yml

You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@rachmari rachmari marked this pull request as ready for review December 15, 2020 16:42
@rachmari rachmari requested a review from a team as a code owner December 15, 2020 16:42
@rachmari rachmari dismissed github-actions[bot]’s stale review December 15, 2020 16:42

Editing the workflow file

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.

  • .github/workflows/triage-unallowed-contributions.yml

You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@rachmari rachmari dismissed github-actions[bot]’s stale review December 15, 2020 16:48

Catches the things it needs to catch.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.

  • .github/workflows/triage-unallowed-contributions.yml

You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@rachmari rachmari closed this Dec 15, 2020
@chiedo chiedo deleted the revert-2098-revert-2094-rachmari-update-unallowed-workflow branch February 1, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants