Revert "Revert "fix some bugs in new workflow""#2099
Conversation
There was a problem hiding this comment.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.
.github/workflows/triage-unallowed-contributions.yml
You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. ![]()
Editing the workflow file
There was a problem hiding this comment.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.
.github/workflows/triage-unallowed-contributions.yml
You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. ![]()
Catches the things it needs to catch.
There was a problem hiding this comment.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.
.github/workflows/triage-unallowed-contributions.yml
You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. ![]()
Why:
The pull request event will run for each new push to the branch, so the
pushevent is not necessary. I've removed the push event and the step that retrieved the pull number when the triggering event was a push.When the check to dismiss a review runs and there are no prior reviews by
github-actions[bot], the check fails in thefromJSONconditional check: https://github.com/github/docs/pull/2062/checks?check_run_id=1548110821I also added a bit more logging for the future just so we have some basic info.
Check off the following: