Skip to content

fixing gh-21736 #21741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 16, 2022
Merged

fixing gh-21736 #21741

merged 18 commits into from
Nov 16, 2022

Conversation

@ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Nov 2, 2022 •
edited by cmwilson21
Loading

Why:

Closes [gh-21736]
Closes #21736

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@ramvikrams
for #21736
9a4035b 
adding `+` for creating unordered list
@ramvikrams
for #21736
fb6cc1d 
adding `+` for creating unordered list and correcting one example
@ramvikrams
for #21736
f98a5aa 
adding `+` for creating unordered list and correcting the examples.
@welcome
Copy link

welcome bot commented Nov 2, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 2, 2022
@ramvikrams ramvikrams changed the title T1 fixing #21736 Nov 2, 2022
@ramvikrams ramvikrams changed the title fixing #21736 fixing gh-21736 Nov 2, 2022
@cmwilson21
Copy link
Contributor

@ramvikrams Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Nov 4, 2022
sophietheking
sophietheking approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramvikrams 👋 Thanks for opening this PR and contributing to our Docs, we really appreciate it! ✨ I made one small change (5178f52). I will approve your PR and get it merged! 🚀

@ramvikrams
Copy link
Contributor Author

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Nov 7, 2022
@cmwilson21 cmwilson21 enabled auto-merge November 11, 2022 15:23
@cmwilson21
Copy link
Contributor

Testing closing and reopening this to rerun the preview deploy.

@cmwilson21 cmwilson21 closed this Nov 11, 2022
auto-merge was automatically disabled November 11, 2022 16:05

Pull request was closed

@cmwilson21 cmwilson21 reopened this Nov 11, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 11, 2022
cmwilson21
cmwilson21 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving review after close/reopen

@cmwilson21 cmwilson21 enabled auto-merge November 11, 2022 16:06
@ramvikrams
Copy link
Contributor Author

Approving review after close/reopen

Thanks

@cmwilson21 cmwilson21 closed this Nov 14, 2022
auto-merge was automatically disabled November 14, 2022 15:22

Pull request was closed

@cmwilson21 cmwilson21 reopened this Nov 14, 2022
@cmwilson21 cmwilson21 enabled auto-merge November 14, 2022 15:23
@gracepark gracepark closed this Nov 16, 2022
auto-merge was automatically disabled November 16, 2022 21:26

Pull request was closed

@gracepark gracepark reopened this Nov 16, 2022
@gracepark gracepark closed this Nov 16, 2022
@gracepark gracepark reopened this Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21 cmwilson21 merged commit 40f8e9b into github:main Nov 16, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@cmwilson21
Copy link
Contributor

@ramvikrams Sorry for the delay! I ran into some technical difficulties while getting this merged. Thanks for the contribution!

@ramvikrams
Copy link
Contributor Author

@ramvikrams Sorry for the delay! I ran into some technical difficulties while getting this merged. Thanks for the contribution!

No problem mam, thanks your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophietheking sophietheking sophietheking approved these changes

+1 more reviewer

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set ready to merge This pull request is ready to merge triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding '+' for creating unordered lists

4 participants

@ramvikrams @cmwilson21 @sophietheking @gracepark