Skip to content

Update docs for generating a new SSH key for windows#2254

Merged
shati-patel merged 3 commits intogithub:mainfrom
williamtorres1:patch-1
Dec 22, 2020
Merged

Update docs for generating a new SSH key for windows#2254
shati-patel merged 3 commits intogithub:mainfrom
williamtorres1:patch-1

Conversation

@williamtorres1
Copy link
Copy Markdown
Contributor

I was trying to add a ssh key to my github using windows 10, and i was uncapable to procceed.
And i found that the commands $ eval $(ssh-agent -s) don't work on windows, but $ evalssh-agent -s works fine

Why:

What's being changed:

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

I was trying to add a ssh key to my github using windows 10, and i was uncapable to procceed.
And i found that the commands `$ eval $(ssh-agent -s)` don't work on windows, but  ` $ eval `ssh-agent -s` ` works fine
@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 21, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

@williamtorres1 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 21, 2020
@shati-patel shati-patel self-assigned this Dec 22, 2020
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works on Windows ✔️

Thank you very much for your contribution @williamtorres1, I'll get this merged once the tests pass 🎉

@Simran-B
Copy link
Copy Markdown
Contributor

In what windows shell does this work?

@shati-patel
Copy link
Copy Markdown
Contributor

In what windows shell does this work?

It should work in a Git Bash shell for Windows 🙂

In fact, both the $ eval $(ssh-agent -s) and $ eval `ssh-agent -s` syntax work in my version, but the latter seems more universal (according to various comments on stackoverflow 😅).

@shati-patel
Copy link
Copy Markdown
Contributor

shati-patel commented Dec 22, 2020

I'm going to quickly close and re-open this PR to (hopefully) kick-start the staging deployment and get the PR checks green 🤞🏽

@shati-patel shati-patel reopened this Dec 22, 2020
@Simran-B
Copy link
Copy Markdown
Contributor

Thanks for the clarification! I missed that the instructions say "Open Git Bash" earlier. I would prefer a true Windows solution that doesn't require an emulated Linux, but this is still a meaningful change.

@shati-patel shati-patel merged commit 596d646 into github:main Dec 22, 2020
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@williamtorres1 williamtorres1 deleted the patch-1 branch December 23, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants