Update docs for generating a new SSH key for windows#2254
Update docs for generating a new SSH key for windows#2254shati-patel merged 3 commits intogithub:mainfrom williamtorres1:patch-1
Conversation
I was trying to add a ssh key to my github using windows 10, and i was uncapable to procceed. And i found that the commands `$ eval $(ssh-agent -s)` don't work on windows, but ` $ eval `ssh-agent -s` ` works fine
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@williamtorres1 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
shati-patel
left a comment
There was a problem hiding this comment.
I can confirm this works on Windows ✔️
Thank you very much for your contribution @williamtorres1, I'll get this merged once the tests pass 🎉
|
In what windows shell does this work? |
It should work in a Git Bash shell for Windows 🙂 In fact, both the |
|
I'm going to quickly close and re-open this PR to (hopefully) kick-start the staging deployment and get the PR checks green 🤞🏽 |
|
Thanks for the clarification! I missed that the instructions say "Open Git Bash" earlier. I would prefer a true Windows solution that doesn't require an emulated Linux, but this is still a meaningful change. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
I was trying to add a ssh key to my github using windows 10, and i was uncapable to procceed.
And i found that the commands
$ eval $(ssh-agent -s)don't work on windows, but$ evalssh-agent -sworks fineWhy:
What's being changed:
Check off the following: