Skip to content

Conversation

@Sriparno08
Copy link
Contributor

@Sriparno08 Sriparno08 commented Dec 13, 2022

Why:

There is an unnecessary comma in the private-repository-forks-overview.md document.

Version: fpt (Free, Pro, or Team plans)

Closes #22494

What's being changed (if available, include any code snippets, screenshots, or gifs):

I have removed the unnecessary comma in the private-repository-forks-overview.md document.

GitHub URL: https://github.com/github/docs/blob/main/data/reusables/actions/private-repository-forks-overview.md#L0-L1

GitHub Docs URL: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Dec 13, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 13, 2022
@cmwilson21
Copy link
Contributor

@Sriparno08 Thanks for submitting a PR! Per this comment, the comma is still necessary for certain versions of documentation and needs to be versioned for those instances. Can you update the PR to include the necessary versioning? You can find out more about our Liquid helpers for versioning here.

@cmwilson21 cmwilson21 added more-information-needed More information is needed to complete review and removed triage Do not begin working on this issue until triaged by the team labels Dec 20, 2022
@Sriparno08 Sriparno08 changed the title Fix: Remove Unnecessary Comma Fix: Remove Unnecessary Comma in Private Forks Documentation Dec 20, 2022
@Sriparno08
Copy link
Contributor Author

Updated it, @cmwilson21!

@Sriparno08
Copy link
Contributor Author

Correctly said, @lecoursen 👍

@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Dec 22, 2022
Copy link

@girlsavenue girlsavenue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmwilson21 cmwilson21 merged commit 3633e95 into github:main Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Sriparno08 Sriparno08 deleted the patch-1 branch January 5, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

more-information-needed More information is needed to complete review ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary comma in private forks test

4 participants