Skip to content

fix typo in Gradle Kotlin DSL script filename extension#2283

Merged
janiceilene merged 4 commits intogithub:mainfrom
HonkingGoose:fix/2259
Dec 23, 2020
Merged

fix typo in Gradle Kotlin DSL script filename extension#2283
janiceilene merged 4 commits intogithub:mainfrom
HonkingGoose:fix/2259

Conversation

@HonkingGoose
Copy link
Copy Markdown
Contributor

@HonkingGoose HonkingGoose commented Dec 22, 2020 •
edited
Loading

Why:

Fixes #2259

What's being changed:

  • Fix typo in Gradle Kotlin DSL script filename extension, (.tks -> .kts)

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@HonkingGoose HonkingGoose mentioned this pull request Dec 22, 2020
Closed
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Dec 22, 2020

Thanks @HonkingGoose! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team labels Dec 22, 2020
runleonarun
runleonarun approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great! Thank you for contributing to our open source project.

@runleonarun runleonarun added the ready to merge This pull request is ready to merge label Dec 22, 2020
@HonkingGoose
Copy link
Copy Markdown
Contributor Author

HonkingGoose commented Dec 23, 2020

@runleonarun Thanks for the compliment! 😄

@janiceilene janiceilene merged commit 59fea64 into github:main Dec 23, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 23, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@HonkingGoose HonkingGoose deleted the fix/2259 branch December 23, 2020 16:25
@snyk-bot snyk-bot mentioned this pull request May 15, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2023
Open
@311821105 311821105 mentioned this pull request Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@runleonarun runleonarun runleonarun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in data reusables.dependabot.supported-package-managers

3 participants

@HonkingGoose @janiceilene @runleonarun