Skip to content

remove "tests are passing" checkbox#2291

Merged
janiceilene merged 1 commit intogithub:mainfrom
HonkingGoose:chore/remove-unnecessary-line-from-pr-template
Dec 22, 2020
Merged

remove "tests are passing" checkbox#2291
janiceilene merged 1 commit intogithub:mainfrom
HonkingGoose:chore/remove-unnecessary-line-from-pr-template

Conversation

@HonkingGoose
Copy link
Copy Markdown
Contributor

Why:

Fixes #2284.

What's being changed:

  • Remove line with checkbox - [ ] All of the tests are passing.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

Copy link
Copy Markdown
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks again @HonkingGoose ⚡ I'll get this merged soon.

@janiceilene janiceilene merged commit 6d50ffd into github:main Dec 22, 2020
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@HonkingGoose HonkingGoose deleted the chore/remove-unnecessary-line-from-pr-template branch December 22, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: remove all test pass checkbox from PR template

3 participants