repo sync

.env.example

@@ -1 +0,0 @@
-ALLOW_TRANSLATION_COMMITS=

.github/CODEOWNERS

@@ -15,11 +15,6 @@ Dockerfile @github/docs-engineering
 package-lock.json @github/docs-engineering
 package.json @github/docs-engineering
 
-# Localization
-/.github/actions-scripts/msft-create-translation-batch-pr.js @github/docs-engineering
-/.github/workflows/msft-create-translation-batch-pr.yml @github/docs-engineering
-/translations/ @Octomerger
-
 # Site Policy
 /content/site-policy/ @github/site-policy-admins
 

.github/actions-scripts/rendered-content-link-checker.js

@@ -11,6 +11,7 @@ import { JSONFile } from 'lowdb/node'
 
 import shortVersions from '../../middleware/contextualizers/short-versions.js'
 import contextualize from '../../middleware/context.js'
+import features from '../../middleware/contextualizers/features.js'
 import getRedirect from '../../lib/get-redirect.js'
 import warmServer from '../../lib/warm-server.js'
 import liquid from '../../lib/render-content/liquid.js'
@@ -165,6 +166,8 @@ if (import.meta.url.endsWith(process.argv[1])) {
  *  patient {boolean} - Wait longer and retry more times for rate-limited external URLS
  *  bail {boolean} - Throw an error on the first page (not permalink) that has >0 flaws
  *  externalServerErrorsAsWarning {boolean} - Treat >=500 errors or temporary request errors as warning
+ *  filter {Array<string>} - strings to match the pages' relativePath
+ *  versions {Array<string>} - only certain pages' versions (e.g. )
  *
  */
 async function main(core, octokit, uploadArtifact, opts = {}) {
@@ -174,6 +177,7 @@ async function main(core, octokit, uploadArtifact, opts = {}) {
     random,
     language = 'en',
     filter,
+    version,
     max,
     verbose,
     checkExternalLinks = false,
@@ -203,8 +207,15 @@ async function main(core, octokit, uploadArtifact, opts = {}) {
   }
 
   const filters = filter || []
-  if (!Array.isArray(filters)) {
-    core.warning(`filters, ${filters} is not an array`)
+  if (filters && !Array.isArray(filters)) {
+    throw new Error(`filters, ${filters} is not an array`)
+  }
+
+  let versions = version || []
+  if (versions && typeof versions === 'string') {
+    versions = [versions]
+  } else if (!Array.isArray(versions)) {
+    throw new Error(`versions, '${version}' is not an array`)
   }
 
   if (random) {
@@ -227,7 +238,9 @@ async function main(core, octokit, uploadArtifact, opts = {}) {
   debugTimeStart(core, 'processPages')
   const t0 = new Date().getTime()
   const flawsGroups = await Promise.all(
-    pages.map((page) => processPage(core, page, pageMap, redirects, opts, externalLinkCheckerDB))
+    pages.map((page) =>
+      processPage(core, page, pageMap, redirects, opts, externalLinkCheckerDB, versions)
+    )
   )
   const t1 = new Date().getTime()
   debugTimeEnd(core, 'processPages')
@@ -554,13 +567,16 @@ function getPages(pageList, languages, filters, files, max) {
     .slice(0, max ? Math.min(max, pageList.length) : pageList.length)
 }
 
-async function processPage(core, page, pageMap, redirects, opts, db) {
+async function processPage(core, page, pageMap, redirects, opts, db, versions) {
   const { verbose, verboseUrl, bail } = opts
-
   const allFlawsEach = await Promise.all(
-    page.permalinks.map((permalink) => {
-      return processPermalink(core, permalink, page, pageMap, redirects, opts, db)
-    })
+    page.permalinks
+      .filter((permalink) => {
+        return !versions.length || versions.includes(permalink.pageVersion)
+      })
+      .map((permalink) => {
+        return processPermalink(core, permalink, page, pageMap, redirects, opts, db)
+      })
   )
 
   const allFlaws = allFlawsEach.flat()
@@ -776,9 +792,17 @@ async function checkHrefLink(
     }
   } else if (href.startsWith('#')) {
     if (checkAnchors) {
-      const countDOMItems = $(href).length
-      if (countDOMItems !== 1) {
-        return { WARNING: `Anchor is an empty string` }
+      // You don't need a DOM ID (or <a name="top">) for `<a href="#top">`
+      // to work in all modern browsers.
+      if (href !== '#top') {
+        // If the link is `#foo` it could either match `<element id="foo">`
+        // or it could match `<a name="foo">`.
+        const countDOMItems = $(href).length + $(`a[name="${href.slice(1)}"]`).length
+        if (countDOMItems === 0) {
+          return { WARNING: `Anchor on the same page can't be found by ID` }
+        } else if (countDOMItems > 1) {
+          return { WARNING: `Matches multiple points in the page` }
+        }
       }
     }
   } else if (href.startsWith('/')) {
@@ -1094,15 +1118,18 @@ async function renderInnerHTML(page, permalink) {
     pagePath,
     cookies: {},
   }
+  // This will create and set `req.context = {...}`
   await contextualize(req, res, next)
   await shortVersions(req, res, next)
-  const context = Object.assign({}, req.context, { page })
-  context.relativePath = page.relativePath
+  req.context.page = page
+  await features(req, res, next)
+
+  req.context.relativePath = page.relativePath
 
   // These lines do what the ubiquitous `renderContent` function does,
   // but at an absolute minimum to get a string of HTML.
-  const markdown = await liquid.parseAndRender(page.markdown, context)
-  const processor = createMinimalProcessor(context)
+  const markdown = await liquid.parseAndRender(page.markdown, req.context)
+  const processor = createMinimalProcessor(req.context)
   const vFile = await processor.process(markdown)
   return vFile.toString()
 }

.github/workflows/hubber-contribution-help.yml

@@ -43,7 +43,8 @@ jobs:
 
           - When you're ready for the Docs team to review this PR, add the *ready-for-doc-review* label to your PR, and it will be automatically added to the [Docs Content review board](https://github.com/orgs/github/memexes/901?layout=table&groupedBy%5BcolumnId%5D=11024). **Please factor in at least 72 hours for a review, even longer if this is a substantial change.**
           - If you're adding a release note, request a technical review. The Docs team will review the PR after the technical review is complete.
-          - If this is a major update to the docs, you might want to go back and open an [issue](https://github.com/github/docs-content/issues/new/choose) to ensure we've covered all areas of the docs in these updates. Not doing so may result in delays or inaccurate documentation."
+          - If your updates to the docs are more than a simple fix, you might want to go back and open an [issue](https://github.com/github/docs-content/issues/new/choose) to ensure we've covered all areas of the docs in these updates. Not doing so may result in delays or inaccurate documentation."
+
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           PR: ${{ github.event.pull_request.html_url }}