Skip to content

Update workflow-syntax-for-github-actions.md#2353

Merged
lucascosti merged 2 commits intogithub:mainfrom
logankilpatrick:patch-1
Jan 18, 2021
Merged

Update workflow-syntax-for-github-actions.md#2353
lucascosti merged 2 commits intogithub:mainfrom
logankilpatrick:patch-1

Conversation

@logankilpatrick
Copy link
Copy Markdown
Contributor

Update bash command for Fail-fast behavior per this thread: https://github.community/t/workflow-default-error-action-preference/149931 validated across multiple resources. See here: https://explainshell.com/explain?cmd=set+-e+o+pipefail and here: https://dougrichardson.us/2018/08/03/fail-fast-bash-scripting.html

Why:

Pointed out in this thread: https://github.community/t/workflow-default-error-action-preference/149931

What's being changed:

Updated Bash command to remove space.

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 26, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

@logankilpatrick Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 28, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 4, 2021
@logankilpatrick
Copy link
Copy Markdown
Contributor Author

Stay alive :)

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@logankilpatrick
Copy link
Copy Markdown
Contributor Author

Please don't close me :')

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@lucascosti lucascosti self-assigned this Jan 18, 2021
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this!

Yep, this is a bug; thanks for the fix! 🚀

@lucascosti lucascosti merged commit 8a4007d into github:main Jan 18, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants