Skip to content

Add an example that helps use custom commands as "shell"#2647

Merged
skedwards88 merged 5 commits intogithub:mainfrom
JJ:patch-1
Jan 25, 2021
Merged

Add an example that helps use custom commands as "shell"#2647
skedwards88 merged 5 commits intogithub:mainfrom
JJ:patch-1

Conversation

@JJ
Copy link
Copy Markdown
Contributor

@JJ JJ commented Jan 7, 2021 •
edited
Loading

And, at the same time, helps people find "perl" as a legit thing in Github Actions.

Why:

#2646

What's being changed:

An example and intro to it is being added.

Check off the following:

@JJ
Add an example that helps use custom command
fcb9122 
And, at the same time, helps people find "perl" as a legit thing in Github Actions.
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 8, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Jan 8, 2021

@JJ Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene linked an issue Jan 8, 2021 that may be closed by this pull request
Add an example for custom shells #2646
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 17, 2021
@JJ
Copy link
Copy Markdown
Contributor Author

JJ commented Jan 17, 2021

Ping?

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Jan 18, 2021
skedwards88
skedwards88 reviewed Jan 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you for adding this example! I made a few suggestions around the wording. Let me know what you think!

Comment thread content/actions/reference/workflow-syntax-for-github-actions.md Outdated
Comment thread content/actions/reference/workflow-syntax-for-github-actions.md Outdated
JJ and others added 2 commits January 23, 2021 09:03
@JJ
Accept suggestion 👍
8694417 
Co-authored-by: Sarah Edwards <skedwards88@github.com>
@JJ
Accept this 👍
33eee7f 
Co-authored-by: Sarah Edwards <skedwards88@github.com>
skedwards88
skedwards88 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! I'll get this merged down for you. Thank you for your contribution!

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jan 25, 2021
@skedwards88 skedwards88 merged commit 1c06a50 into github:main Jan 25, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 25, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skedwards88 skedwards88 skedwards88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an example for custom shells

4 participants

@JJ @janiceilene @skedwards88 @jmarlena