Skip to content

Close #2625 by updating method to enable Dependabot security updates#2662

Merged
hubwriter merged 7 commits intogithub:mainfrom
hamirmahal:fix/dependabot-updates-docs
Jan 15, 2021
Merged

Close #2625 by updating method to enable Dependabot security updates#2662
hubwriter merged 7 commits intogithub:mainfrom
hamirmahal:fix/dependabot-updates-docs

Conversation

@hamirmahal
Copy link
Copy Markdown
Contributor

@hamirmahal hamirmahal commented Jan 7, 2021

Why:

As mentioned in #2625, the documentation for enabling automated Dependabot security updates appears to be out-of-date.

What's being changed:

I'm changing steps two, three and four of the "Managing Dependabot security updates for your repositories" section of the "Configuring Dependabot security updates" page to match what I think is the new user interface for enabling Dependabot security updates.

In this pull request, I removed what I think is an out-of-date screenshot and replaced it with a screen capture that I think matches the current user interface.

Original:

current appearance of "Managing Dependabot security updates for your repositories" section of the "Configuring Dependabot security updates" page

Appearance with changes from this pull request:

appearance of "Managing Dependabot security updates for your repositories" section of the "Configuring Dependabot security updates" page with changes from this pull request

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

@hamirmahal Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team DSP labels Jan 8, 2021
@hamirmahal
Copy link
Copy Markdown
Contributor Author

@janiceilene You're welcome! Happy to help.

@hubwriter hubwriter self-assigned this Jan 11, 2021
@hubwriter
Copy link
Copy Markdown
Contributor

@hamirmahal - Many thanks for raising this PR. That's a good catch and a great fix. 👍

I'm going to make a slight modification just to make it clear that the procedure refers to enabling/disabling Dependabot security updates on a single repository, and also to match the instructions we give in the related "Managing security and analysis settings for your repository" topic.

Thanks again for helping to keep GitHub documentation up to date. Your assistance is very much appreciated!

@hubwriter
Copy link
Copy Markdown
Contributor

hubwriter commented Jan 11, 2021

See my changes to this PR in this commit: 5a0a1b1

Staged deployment of the updated page is here: https://docs-2662--fixdependabot-updat.herokuapp.com/en/free-pro-team@latest/github/managing-security-vulnerabilities/configuring-dependabot-security-updates#managing-dependabot-security-updates-for-your-repositories

@hamirmahal - let me know if you agree with my change to your PR and I'll get this merged and deployed. Thanks again

@janiceilene janiceilene linked an issue Jan 11, 2021 that may be closed by this pull request
@hamirmahal
Copy link
Copy Markdown
Contributor Author

@hubwriter You're welcome! Happy to help.

I think there's a typo at the very end of line 56 in content/github/managing-security-vulnerabilities/configuring-dependabot-security-updates.md.

I think fixing the typo is my only suggested change. I gave a couple of alternatives.

Thanks for the direct preview link! That saves me a bit of time so I don't have to find the page again, since I didn't bookmark the preview link.

Copy link
Copy Markdown
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamirmahal - typo corrected, thanks.

I'll get this merged now.

@hubwriter hubwriter merged commit 43dd16f into github:main Jan 15, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@hamirmahal hamirmahal deleted the fix/dependabot-updates-docs branch January 15, 2021 19:28
@hamirmahal
Copy link
Copy Markdown
Contributor Author

@hubwriter You're welcome! Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update methodology for enabling Dependabot security updates

3 participants