Skip to content

Add some missing properties on workflow_run events#2767

Merged
lucascosti merged 5 commits intogithub:mainfrom
sbrunner:workflow_run_properties
Mar 17, 2021
Merged

Add some missing properties on workflow_run events#2767
lucascosti merged 5 commits intogithub:mainfrom
sbrunner:workflow_run_properties

Conversation

@sbrunner
Copy link
Copy Markdown
Contributor

@sbrunner sbrunner commented Jan 11, 2021

Why:

Fix #2599

What's being changed:

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 11, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

@sbrunner Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 11, 2021
@sbrunner
Copy link
Copy Markdown
Contributor Author

@janiceilene what's the status?

@janiceilene
Copy link
Copy Markdown
Contributor

@sbrunner Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 27, 2021
@sbrunner
Copy link
Copy Markdown
Contributor Author

UP

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Jan 28, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions Bot closed this Feb 13, 2021
@sbrunner
Copy link
Copy Markdown
Contributor Author

What does the close by github-actions means?

@janiceilene
Copy link
Copy Markdown
Contributor

So sorry about that @sbrunner! It looks like our new action inadvertently closed this 🙃 Reopening and triaging this for review 💛

@janiceilene janiceilene reopened this Feb 16, 2021
@sbrunner
Copy link
Copy Markdown
Contributor Author

@janiceilene Thanks :-)

@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 18, 2021
@skedwards88 skedwards88 self-assigned this Mar 2, 2021
@skedwards88 skedwards88 removed their assignment Mar 4, 2021
@lucascosti lucascosti self-assigned this Mar 17, 2021
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these changes, @sbrunner!

For the workflow run properties: because they're largely identical to the check suite ones, instead of repeating them I've edited your table to consolidate the descriptions and link to the check suite descriptions.

Because I've made a few changes, I'll get one of the other writers on the team to double-check this PR 👍

Stage: https://docs-2767--workflow-run-proper.herokuapp.com/en/developers/webhooks-and-events/webhook-events-and-payloads#workflow_run

Copy link
Copy Markdown
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for this PR! 🎊 🎉

@lucascosti lucascosti merged commit 0d0d3c0 into github:main Mar 17, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@sbrunner
Copy link
Copy Markdown
Contributor Author

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The workflow_run payload docs is incomplete

5 participants