Skip to content

Revise two repo.archive entry names, add several#2826

Merged
shati-patel merged 2 commits intomainfrom
solvaholic-patch-1
Jan 29, 2021
Merged

Revise two repo.archive entry names, add several#2826
shati-patel merged 2 commits intomainfrom
solvaholic-patch-1

Conversation

@solvaholic
Copy link
Copy Markdown
Contributor

@solvaholic solvaholic commented Jan 12, 2021

👋 Hiyo!

I'm creating this pull request to log the feedback and, as a start, make the first two proposed changes.

How should one go about making the additions?

I imagine some entries may have changed somewhat between versions, or may have intentionally been omitted.

Why:

A QRadar SIEM user reported the following about this document. They're running GitHub Enterprise Server 2.22.

  1. Instead of repo.archive, we see repo.archived
  2. Instead of repo.unarchive we see repo.unarchived
  3. Events not documented, but visible in the audit logs:
config_entry.create 
config_entry.destroy 
deceased_user.create 
issue.pinned 
issue_comment.destroy 
oauth_authorization.destroy 
repo.archived 
repo.change_merge_setting 
repo.disk_archive 
repo.unarchived 
staff.repo_lock 
staff.search_audit_log 
staff.view_audit_log

What's being changed:

Revise two repo.archive entry names, add several entries, per comment above.

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 12, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks for opening a PR @solvaholic! I'll get this triaged for the team to take a look 👀

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 12, 2021
@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 21, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 21, 2021
@shati-patel shati-patel self-assigned this Jan 29, 2021
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback and the pull request, @solvaholic!

I'll get these changes merged, and I've opened an internal issue to track the remaining missing events 😃

You're welcome to open another PR to add those events, or drop more information into that issue for the docs team to pick up 📝

@shati-patel shati-patel merged commit d0b17b7 into main Jan 29, 2021
@shati-patel shati-patel deleted the solvaholic-patch-1 branch January 29, 2021 14:05
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants