-
Notifications
You must be signed in to change notification settings - Fork 64.4k
doc(oidc): policy example does not work when environments are in use #28291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(oidc): policy example does not work when environments are in use #28291
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
The documentation depicting how to limit scope of access in the trust policy works for *most* cases. However when a deployment environment is used by a job, the policy will not work. This is described in the linked documentation here: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#example-subject-claims You can test your Github actions runs to verify what claim you need using this action: https://github.com/github/actions-oidc-debugger
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
|
@therealvio Thanks for submitting a PR! I edited your post slightly to link it to your issue 👍 We generally don't accept contributions to these files, as you stated, but would you mind marking this PR as "Ready"? I can mention it to the team and we can decide if we need to make this change internally or not. Thank you for your interest in improving GitHub Docs! 💖 |
|
Thank you! @cmwilson21 I have promoted the PR from draft :) |
|
✨Thank you for contributing with this @therealvio! It does seem like it would be helpful to link to "Filtering for a specific branch" in this AWS example as you're suggesting. Since these are restricted files, I'll go ahead open up an internal issue and we will be able to make the fix from there. |
|
Love to see it, thanks @jc-clark! |
The documentation depicting how to limit scope of access in the trust policy works for most cases. However when a deployment environment is used by a branch, the policy will not work. This is described in the linked documentation here:
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#example-subject-claims
You can test your Github actions runs to verify what claim you need using this action: https://github.com/github/actions-oidc-debugger
Why:
Closes: #28292
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.