Skip to content

Updated gradle cache example#2900

Merged
lucascosti merged 5 commits intogithub:mainfrom
odin-delrio:patch-1
Jan 21, 2021
Merged

Updated gradle cache example#2900
lucascosti merged 5 commits intogithub:mainfrom
odin-delrio:patch-1

Conversation

@odin-delrio
Copy link
Copy Markdown
Contributor

@odin-delrio odin-delrio commented Jan 15, 2021

Why:

The example using gradle caches is outdated according to https://github.com/actions/cache/blob/main/examples.md#java---gradle (wich I changed with a PR recently), if copied&pasted could cause gradle builds in GH Actions to not use the cache properly (causing slower builds than needed).

What's being changed:

The example using gradle caches.

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 15, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

@odin-delrio Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 15, 2021
@lucascosti lucascosti self-assigned this Jan 21, 2021
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating this, @odin-delrio! I'll just do a tiny update to the wording, and then merge this in 👍

Comment thread content/actions/guides/building-and-testing-java-with-gradle.md Outdated
@lucascosti lucascosti merged commit fc79ca0 into github:main Jan 21, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants