Updated gradle cache example#2900
Merged
lucascosti merged 5 commits intogithub:mainfrom Jan 21, 2021
Merged
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@odin-delrio Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
lucascosti
approved these changes
Jan 21, 2021
Contributor
lucascosti
left a comment
There was a problem hiding this comment.
Thanks a lot for updating this, @odin-delrio! I'll just do a tiny update to the wording, and then merge this in 👍
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The example using gradle caches is outdated according to https://github.com/actions/cache/blob/main/examples.md#java---gradle (wich I changed with a PR recently), if copied&pasted could cause gradle builds in GH Actions to not use the cache properly (causing slower builds than needed).
What's being changed:
The example using gradle caches.
Check off the following: