Skip to content

(fix) update about-dependabot-version-updates.md#2946

Merged
felicitymay merged 3 commits intogithub:mainfrom
vladdoster:patch-2
Feb 1, 2021
Merged

(fix) update about-dependabot-version-updates.md#2946
felicitymay merged 3 commits intogithub:mainfrom
vladdoster:patch-2

Conversation

@vladdoster
Copy link
Copy Markdown
Contributor

@vladdoster vladdoster commented Jan 17, 2021

Note: The source diff is not very helpful. Try using the Rich diff to see changes.

  • into is a preposition that shows what something is within or inside
  • reduce verbosity
  • punctuation
  • remove split infinitive which makes writing less formal and hard for non-native speakers to understand.

Why:

Documentation writing is incorrect and makes it confusing.

What's being changed:

dependabot documentation

Check off the following:

- `into` is a preposition that shows what something is within or inside
- reduce verbosity
- punctuation
- remove split infinitive which makes writing less formal and hard for non-native speakers to understand.
@janiceilene
Copy link
Copy Markdown
Contributor

@vladdoster Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team DSP labels Jan 19, 2021
Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vladdoster 👋🏻

Thank for your changes and also for the helpful reminder that the changes would be easier to review using the rich text diff 😄

I was interested to read: "remove split infinitive which makes writing less formal and hard for non-native speakers to understand.".

As a native English speaker, I hated reading sentences with a split infinitive when I first started seeing them. Now there are times, like here, where I find it clearer to read the verb and adverb together. So it is very interesting to hear that this makes the sentence more difficult for a non-native speaker. Thank you for sharing the perspective.

I have one suggested change and will be happy to merge this PR once that change, or an alternative fix, is accepted.

Comment thread content/github/administering-a-repository/about-dependabot-version-updates.md Outdated
vladdoster and others added 2 commits January 30, 2021 00:02
…sion-updates.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>
@felicitymay felicitymay merged commit 307a8fe into github:main Feb 1, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants