Skip to content

Update generating-a-json-web-token-jwt-for-a-github-app.md#30554

Merged
skedwards88 merged 2 commits intogithub:mainfrom
mark-mxwl:patch-5
Dec 11, 2023
Merged

Update generating-a-json-web-token-jwt-for-a-github-app.md#30554
skedwards88 merged 2 commits intogithub:mainfrom
mark-mxwl:patch-5

Conversation

@mark-mxwl
Copy link
Copy Markdown
Contributor

Why:

Closes: #29925

What's being changed (if available, include any code snippets, screenshots, or gifs):

Provided a working bash script for generating a JWT signed with RS256, as proposed in the comments. The script contains all of the required claims, and has been tested locally with the following sample usage and output:

Usage:

./JWT5.sh 1234 BashPEM.pem

Output:

JWT: ewogICAgInR5cCI6IkpXVCIsCiAgICAiYWxnIjoiUlMyNTYiCn0.ewogICAgImlhdCI6MTcwMjI0MDIxNiwKICAgICJleHAiOjE3MDIyNDA4NzYsCiAgICAiaXNzIjoxMjM0Cn0.UnXejj2L8UOBtTkRIxqf7nqnQGRaMr-fx9GN7XIPo3yeLOYYNRNjCZDcQq0f9gqMwy1s1eZmBCFzDpdzlaTbxAGK865tSOX97KREx5XmC8pKBfYBYjWDCMQY2PBngSQtPU0ZN-OFi7CSS-Fec5GvejBZIfjAsCmC8XrKFSVyCEWEiFoIjfhGnsaZ-aQDBqsVgS42Sk0XPYF4Pm2EB0Yxt2rzsncgWRCGd9kj-EG5JbnJKm8DQtk5eHaLasJlHSDVVSSLc0-y_el02RxUkH2QiUsObZOftQAIzgFWrGvsM08mwvahPB6miaP_CiT5cDt3H1zuWTaDkzyUbqhMzZZialQqxuRkt8hNoZhdToKJp_mkNV1Qsss_pXWdCSDM0gvlWr7mU0bEiKczyWNR0f5jNZfZJbnknTfSttzcTcFbAXw2iWIxRNTRd_FqFVZYN3RXA9dAiq5l78ny5WLaWyLRyJjrIVioRY2F1pgxL1De4KlUn6NX1EbxzNNQjiGc7Yru

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Provided a working bash script for generating a JWT, as proposed in the linked issue.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 10, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@nguyenalex836
Copy link
Copy Markdown
Contributor

@mark-mxwl Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels Dec 11, 2023
@mark-mxwl
Copy link
Copy Markdown
Contributor Author

Thx @nguyenalex836!

Copy link
Copy Markdown
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example! I left some very minor suggestions that I will go ahead and incorporate, then we'll get this merged for you.

@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Dec 11, 2023
@skedwards88 skedwards88 added this pull request to the merge queue Dec 11, 2023
@mark-mxwl
Copy link
Copy Markdown
Contributor Author

Amazing, thx so much @skedwards88!! This was a fun one 🙌

Merged via the queue into github:main with commit 1aac8c5 Dec 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pure shell script example

4 participants