Skip to content

Conversation

@raiden-e
Copy link

Update for windows users

Why:

See #3072

What's being changed:

chmod +x goodbye.sh

will be changed to:

# bash
chmod +x goodbye.sh
# Windows PowerShell
git update-index --chmod=+x ./goodbye.sh

@welcome
Copy link

welcome bot commented Jan 22, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Author

@raiden-e raiden-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed formatting, for more overview

@janiceilene
Copy link
Contributor

@raiden-e Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Jan 22, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 30, 2021
@raiden-e raiden-e marked this pull request as ready for review January 31, 2021 10:39
@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 31, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
@raiden-e
Copy link
Author

This is the first time i've tried to contribute to open source ... If anything is wrong with this please let me know

@janiceilene
Copy link
Contributor

I'm so sorry @raiden-e! You did absolutely nothing wrong. It looks like our new action inadvertently closed this 🙃 Reopening and triaging this for review 💛

@janiceilene janiceilene reopened this Feb 16, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@skedwards88
Copy link
Contributor

Thank you for this contribution! We also have a larger issue here for supporting alternative shells: #253

I am not familiar with PowerShell. To help me validate your contribution, you include a screenshot in a comment or the original post?

@skedwards88 skedwards88 added triage Do not begin working on this issue until triaged by the team and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 4, 2021
@clubiriesouthbaya

This comment has been minimized.

@raiden-e
Copy link
Author

raiden-e commented Mar 12, 2021

Thank you for this contribution! We also have a larger issue here for supporting alternative shells: #253

I am not familiar with PowerShell. To help me validate your contribution, you include a screenshot in a comment or the original post?

I hope this helps...
image

@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 16, 2021
@martin389
Copy link
Contributor

Thank you for this PR, I think this would definitely help make things smoother for Windows users 🎊

Thanks for uploading the screenshot. Would you be able to follow the steps at https://docs.github.com/en/actions/creating-actions/creating-a-composite-run-steps-action (but using git update-index --chmod=+x ./goodbye.sh) and then share the results in a public repo for us to check?

@raiden-e
Copy link
Author

Thank you for this PR, I think this would definitely help make things smoother for Windows users 🎊

Thanks for uploading the screenshot. Would you be able to follow the steps at https://docs.github.com/en/actions/creating-actions/creating-a-composite-run-steps-action (but using git update-index --chmod=+x ./goodbye.sh) and then share the results in a public repo for us to check?

I used to work on this: https://github.com/raiden-e/powershell-actions, in which I used to follow the steps while using the given command.

@martin389
Copy link
Contributor

Hi @raiden-e 👋

I wanted to add some updates to this PR, but it looks like the original fork was deleted. Would you be able to create a new PR and keep your fork around until the PR is merged?

I also had some suggestions for your new PR:

  1. The "Prerequisites" step 4 could be replaced by echo "echo Goodbye" > goodbye.sh
  2. To make the file executable from windows, it looks like the preference is to use git add --chmod=+x -- goodbye.sh. It might be clearer if we create a separate tab for the Windows instructions, similar to approach taken here: https://docs.github.com/en/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.

@martin389
Copy link
Contributor

Thank you for your help so far, @raiden-e 🎊
I'm closing this PR so that another can be created, as per #3073 (comment) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Actions Creating a composite run steps action for windows users

8 participants