Skip to content

Conversation

@setchy
Copy link
Contributor

@setchy setchy commented Feb 17, 2024

Why:

Closes: #31697

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 17, 2024
@setchy setchy changed the title docs: add member_feature_requested reason docs(notifications): add missing member_feature_requested reason Feb 17, 2024
@setchy
Copy link
Contributor Author

setchy commented Feb 17, 2024

I'm not familiar this this notification reason type, so welcome suggestions on an appropriate description.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
rest/activity/notifications.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@setchy Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team rest Content related to rest - overview. waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 19, 2024
@skedwards88 skedwards88 added the needs SME This proposal needs review from a subject matter expert label Feb 21, 2024
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@skedwards88
Copy link
Contributor

(Internal note: Asked for SME assistance for filling in the missing description here)

@setchy
Copy link
Contributor Author

setchy commented Feb 21, 2024

Suggestion incorporated

@nguyenalex836
Copy link
Contributor

@setchy Thanks for incorporating that suggestion! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Feb 21, 2024
Merged via the queue into github:main with commit 4a33e53 Feb 21, 2024
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@setchy setchy deleted the patch-4 branch February 21, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert rest Content related to rest - overview. waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Notifications REST API missing member_feature_requested reason

4 participants