Skip to content

Conversation

@hsnabszhdn
Copy link
Contributor

@hsnabszhdn hsnabszhdn commented Feb 17, 2024

Why:

Noticed there are places where the style guides isn't followed.

Closes: N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

a) Use quotation marks instead of boldface for UI elements that cannot be interacted with.

  • IMPORTANT: I don't have an organization to see whether "Projects" or "Projects (classic) only" are sections or interactable UI elements, but based on the word "under" preceding them, I assume they cannot be interacted with, hence no boldface. Would appreciate reviewers' double check 🙏

Reference: User interface text

Use quotation marks to surround UI text that cannot be interacted with.

b) Use the word "deselect" instead of "unselect"

Reference: Checkboxes

To describe choosing or clearing a checkbox, use “select” or “deselect.”

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
organizations/managing-organization-settings/disabling-project-boards-in-your-organization.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team organizations Content related to organizations and removed triage Do not begin working on this issue until triaged by the team labels Feb 19, 2024
@nguyenalex836
Copy link
Contributor

@itecompro Thanks so much for opening a PR with these fixes! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Feb 19, 2024
Merged via the queue into github:main with commit 276e09a Feb 19, 2024
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@hsnabszhdn hsnabszhdn deleted the fix/apply-style-guides-to-disable-projects branch February 21, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team organizations Content related to organizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants