Skip to content

Update why-wasnt-my-application-for-a-student-developer-pack-approved.md#3415

Merged
myarb merged 5 commits intogithub:mainfrom
VibhuRajput:patch-1
Feb 25, 2021
Merged

Update why-wasnt-my-application-for-a-student-developer-pack-approved.md#3415
myarb merged 5 commits intogithub:mainfrom
VibhuRajput:patch-1

Conversation

@VibhuRajput
Copy link
Copy Markdown
Contributor

@VibhuRajput VibhuRajput commented Feb 2, 2021

Why:

Made the document less ambiguous

What's being changed:

The initial doc was good but I made it more easy to understand for beginners and reduced the ambiguity by using descriptive language.
READY FOR REVIEW

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 2, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@VibhuRajput
Copy link
Copy Markdown
Contributor Author

The initial doc was good but I made it more easy to understand for beginners and reduced the ambiguity by using descriptive language.

Copy link
Copy Markdown
Contributor

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this wording?

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Feb 4, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

@VibhuRajput Thanks so much for filling out the template! I've triaged this for the team ✨

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@VibhuRajput
Copy link
Copy Markdown
Contributor Author

@VibhuRajput Thanks so much for filling out the template! I've triaged this for the team ✨

Thanks @janiceilene

@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@myarb myarb dismissed a stale review via 69f57b6 February 25, 2021 15:44
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@myarb myarb added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 25, 2021
Copy link
Copy Markdown
Contributor

@myarb myarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR, @VibhuRajput, and that great review, @HonkingGoose 🎉 I've committed your suggestions and we'll get this merged 🔜 ✨

@myarb myarb merged commit 6313aaf into github:main Feb 25, 2021
@HonkingGoose
Copy link
Copy Markdown
Contributor

Cheers @myarb! Thanks for including my suggestions! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants