Skip to content

Add keyboard shortcut for toggling annotations#3899

Merged
janiceilene merged 2 commits intomainfrom
td/hotkey-toggle-all-annotations-docs
Feb 26, 2021
Merged

Add keyboard shortcut for toggling annotations#3899
janiceilene merged 2 commits intomainfrom
td/hotkey-toggle-all-annotations-docs

Conversation

@aaron-tdouble
Copy link
Copy Markdown
Contributor

@aaron-tdouble aaron-tdouble commented Feb 22, 2021

Why:

The Special Projects team recently released a feature that allows a user the ability to toggle all diff annotations via the a hotkey across all files, similar to the way that i does for comments.

This change adds the hotkey to the docs to increase exposure of this new ability.

Issue: https://github.com/github/special-projects/issues/89
Merged github PR: https://github.com/github/github/pull/171199

Closes [issue link] #3900

What's being changed:

Adding this hotkey entry:

Keyboard shortcuts - GitHub Docs 2021-02-22 14-35-43

Check off the following:

  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 22, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@aaron-tdouble aaron-tdouble marked this pull request as ready for review February 22, 2021 19:47
@aaron-tdouble
Copy link
Copy Markdown
Contributor Author

@Devilishhh thanks for the approval. The PR is still showing as needing at least one approval which is weird (since you obviously approved). What do I need to do in order to allow this to be merged?

Copy link
Copy Markdown

@Devilishhh Devilishhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be merged

@Devilishhh
Copy link
Copy Markdown

Devilishhh commented Feb 23, 2021

@Devilishhh thanks for the approval. The PR is still showing as needing at least one approval which is weird (since you obviously approved). What do I need to do in order to allow this to be merged?

Needs to be merged by someone that is authorised to do so @aaron-tdouble

@janiceilene
Copy link
Copy Markdown
Contributor

@aaron-tdouble Thanks so much for opening a PR and an issue! I'll get this triaged for writer review ⚡

In the future, could you open an issue in docs content? That'll give writers an opportunity to weigh in on what changes will be needed (that plan is outlined in https://github.com/github/docs-team/issues/340#issuecomment-769974718).

@janiceilene janiceilene linked an issue Feb 23, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great!

@janiceilene janiceilene merged commit 68a4df9 into main Feb 26, 2021
@janiceilene janiceilene deleted the td/hotkey-toggle-all-annotations-docs branch February 26, 2021 17:37
Copy link
Copy Markdown

@Devilishhh Devilishhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add annotation toggle hotkey

4 participants