-
Notifications
You must be signed in to change notification settings - Fork 65.8k
Updated dependabot's docs to add Gradle Wrapper
#39954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gmazzo
wants to merge
5
commits into
github:main
Choose a base branch
from
gmazzo:dependabot-gradle-wrapper-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aee5abe
Updated `dependabot`'s docs to add `Gradle Wrapper`
gmazzo 9bd0c80
Update Gradle wrapper description in documentation
kbukum1 9675fd8
Explain the dependency name for the Gradle Wrapper (#1)
yeikel c68dbb5
Document that Gradle runs when updating the Gradle Wrapper (#2)
yeikel 43470eb
Merge branch 'github:main' into dependabot-gradle-wrapper-support
gmazzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -122,18 +122,26 @@ For more information about using {% data variables.product.prodname_dependabot_v | |||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| {% data variables.product.prodname_dependabot %} doesn't run Gradle but supports updates to the following files: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `build.gradle`, `build.gradle.kts` (for Kotlin projects) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradle/wrapper/gradle-wrapper.properties` (for Gradle wrapper) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradle/libs.versions.toml` (for projects using a standard Gradle version catalog) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradle.lockfile` (for projects using Gradle dependency locking) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradle/wrapper/gradle-wrapper.properties` (for the Gradle Wrapper) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * Files included via the `apply` declaration that have `dependencies` in the filename. Note that `apply` does not support `apply to`, recursion, or advanced syntaxes (for example, Kotlin's `apply` with `mapOf`, filenames defined by property). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| {% data variables.product.prodname_dependabot %} runs Gradle to update the Gradle Wrapper: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradle/wrapper/gradle-wrapper.properties` | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradlew` | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradlew.bat` | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| * `gradle/wrapper/gradle-wrapper.jar` | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
123
to
+136
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks good to me. Thanks for the suggestions |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| {% data variables.product.prodname_dependabot %} uses information from the `pom.xml` file of dependencies to add links to release information in update pull requests. If the information is omitted from the `pom.xml` file, then it cannot be included in {% data variables.product.prodname_dependabot %} pull requests, see [AUTOTITLE](/code-security/dependabot/ecosystems-supported-by-dependabot/optimizing-java-packages-dependabot). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| For {% data variables.product.prodname_dependabot_security_updates %}, Gradle support is limited to manual uploads of the dependency graph data using the {% data variables.dependency-submission-api.name %}. For more information about the {% data variables.dependency-submission-api.name %}, see [AUTOTITLE](/code-security/supply-chain-security/understanding-your-software-supply-chain/using-the-dependency-submission-api). | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| > [!NOTE] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| > * When you upload Gradle dependencies to the dependency graph using the {% data variables.dependency-submission-api.name %}, all project dependencies are uploaded, even transitive dependencies that aren't explicitly mentioned in any dependency file. When an alert is detected in a transitive dependency, {% data variables.product.prodname_dependabot %} isn't able to find the vulnerable dependency in the repository, and therefore won't create a security update for that alert. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| > * {% data variables.product.prodname_dependabot_version_updates %} will, however, create pull requests when the parent dependency is explicitly declared as a direct dependency in the project's manifest file. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| > * When updating the Gradle Wrapper, {% data variables.product.prodname_dependabot %} uses `gradle-wrapper` for the dependency name. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ### Helm Charts | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can change it something like the following
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to craft any wording that fits better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmazzo
Thanks. It will be great if you guys can review it since docs are important from user perspective.
CC: @yeikel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added suggestion here. Let me know what do you think.