Skip to content

Add information about steps required before importing your migrated data.#4007

Merged
rachmari merged 5 commits intomainfrom
kwacky1-migration-clarify
Mar 1, 2021
Merged

Add information about steps required before importing your migrated data.#4007
rachmari merged 5 commits intomainfrom
kwacky1-migration-clarify

Conversation

@kwacky1
Copy link
Copy Markdown
Contributor

@kwacky1 kwacky1 commented Feb 26, 2021

Why:

If you land on this page from a search, there is no indication that prior steps are required.

What's being changed:

A small preamble is added before the process that mentions and links to the previous steps

Check off the following:

@kwacky1 kwacky1 requested a review from felicitymay February 26, 2021 04:10
@kwacky1 kwacky1 self-assigned this Feb 26, 2021
@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 26, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR. It's a good call to add this extra context to the start of this procedure for people who arrive from a search ✨

There's one change needed to bring this into line with our localization guidelines. Otherwise this looks like a great change.

You can see your changes on staging here: https://docs-4007--kwacky1-migration-c.herokuapp.com/en/enterprise-server@3.0/admin/user-management/migrating-data-to-your-enterprise.

Comment thread content/admin/user-management/migrating-data-to-your-enterprise.md Outdated
@sartgoo
Copy link
Copy Markdown

sartgoo commented Feb 28, 2021

team-review-requested:[TEAMNAME4007[USERNAME]

Co-authored-by: Felicity Chapman <felicitymay@github.com>
@kwacky1 kwacky1 dismissed a stale review via 335a0c3 February 28, 2021 23:56
@kwacky1 kwacky1 requested a review from felicitymay February 28, 2021 23:57
Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks ready to merge once the repository is unfrozen (should be today).

@felicitymay felicitymay added the ready to merge This pull request is ready to merge label Mar 1, 2021
@rachmari rachmari enabled auto-merge (squash) March 1, 2021 22:11
@rachmari rachmari merged commit 065801d into main Mar 1, 2021
@rachmari rachmari deleted the kwacky1-migration-clarify branch March 1, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants