Add ChromeOS support in defaultPlatform frontmatter#4102
Add ChromeOS support in defaultPlatform frontmatter#4102heiskr merged 5 commits intogithub:mainfrom sirocyl:main
Conversation
Adds CrOS to defaultPlatform frontmatter, as Linux.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@sirocyl Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
|
Oh, I think we'll need to update our event schema too; so that analytics events coming from ChromeOS pass the validation. https://github.com/sirocyl/docs/blob/main/lib/schema-event.js#L76 |
|
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
|
I don't think this one's stale! Reopening. |
|
Just checking in - is there anything I need to do here, or are we just waiting to move through the pipeline? |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Adds CrOS to defaultPlatform frontmatter, as a variant of Linux.
Why:
As noted in #4101, ChromeOS is not identified in pages which have multiple platform-specific parts.
What's being changed:
This change:
user-agent.js, anddisplay-platform-specific-content.js.Check off the following: