Fix .env examples for PRIVATE_KEY -> GITHUB_PRIVATE_KEY variables#4305
Fix .env examples for PRIVATE_KEY -> GITHUB_PRIVATE_KEY variables#4305hubwriter merged 2 commits intogithub:mainfrom
PRIVATE_KEY -> GITHUB_PRIVATE_KEY variables#4305Conversation
This fixes naming for a couple of variables in the `.env` examples in this document. Currently there are examples which suggest naming the private key variable `PRIVATE_KEY`, when really it should be `GITHUB_PRIVATE_KEY`. When following along in the example and attempting to run the server, using the incorrect name in the `.env` file leads to an error.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
Thanks so much for opening an issue and a PR for this change @schlagelk! I'll get this triaged for review ⚡ |
hubwriter
left a comment
There was a problem hiding this comment.
@schlagelk - Thanks so much for correcting this. I hope this error didn't inconvenience you too much when you ran up against it. Very good of you to take time to correct it. Much appreciated. 👍
Thanks again. I'll merge this to get this correction live.
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
This fixes naming for a couple of variables in the
.envexamples in this document. Currently there are examples which suggest naming the private key variablePRIVATE_KEY, when really it should beGITHUB_PRIVATE_KEY. When following along in the example and attempting to run the server, using the incorrect name in the.envfile leads to an error.Closes [https://github.com//issues/4304]
What's being changed:
PRIVATE_KEY->GITHUB_PRIVATE_KEYCheck off the following: