Skip to content

Missing bundle install in testing pages locally#4412

Merged
shati-patel merged 3 commits intogithub:mainfrom
marie-bnl:patch-1
Mar 30, 2021
Merged

Missing bundle install in testing pages locally#4412
shati-patel merged 3 commits intogithub:mainfrom
marie-bnl:patch-1

Conversation

@marie-bnl
Copy link
Copy Markdown
Contributor

Why:

Without doing bundle install it gives

> bundle exec jekyll serve .
bundler: command not found: jekyll
Install missing gem executables with `bundle install`

What's being changed:

image

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 9, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

@victorbnl Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilene janiceilene added pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review labels Mar 16, 2021
@shati-patel shati-patel self-assigned this Mar 30, 2021
@shati-patel shati-patel dismissed a stale review via 95e3cff March 30, 2021 17:39
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @victorbnl, much appreciated! I'll get this merged shortly 😃

@shati-patel shati-patel added the ready to merge This pull request is ready to merge label Mar 30, 2021
@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Mar 30, 2021
@shati-patel shati-patel enabled auto-merge (squash) March 30, 2021 17:42
@shati-patel shati-patel merged commit ca73a4a into github:main Mar 30, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pages Content related to GitHub Pages ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants