Skip to content

Conversation

@StarTrooper08
Copy link
Contributor

@StarTrooper08 StarTrooper08 commented Mar 12, 2021

changes made for issue no #2919

Why:

Closes [issue link]

What's being changed:

Check off the following:

@theerapong2425

This comment has been minimized.

@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 24, 2021
@StarTrooper08
Copy link
Contributor Author

@janiceilene where I will get those
Instance .Can I get one example .I m not getting those instances for 3 fix

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Mar 26, 2021
@lee-dohm
Copy link
Contributor

@StarTrooper08 You can find an example of the three of them together here:

https://github.com/github/docs/blame/main/content/developers/github-marketplace/applying-for-publisher-verification-for-your-organization.md#L18-L20

What we need for you to do is to find all instances of this pattern in the entire project and change it to the second pattern as described in this comment. The most efficient way to do that is to make the changes with a text editor on your local computer rather than through the GitHub website. If you're unfamiliar with how to perform this task in your text editor, you'l have to consult your editor's documentation, specifically "Find in Files" or "Find in Project" is what the feature is typically called in most editors.

I hope that helps!

@StarTrooper08
Copy link
Contributor Author

Thanks ,I should start working on it now.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Apr 6, 2021
@StarTrooper08
Copy link
Contributor Author

@janiceilene I have done with few changes for instances mentioned. Work is in progress.
I will have pr in few days

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Apr 7, 2021
@janiceilene
Copy link
Contributor

Awesome @StarTrooper08! Thanks for the update 🎉

@StarTrooper08
Copy link
Contributor Author

StarTrooper08 commented Apr 13, 2021

githubchanges2.PNG

So far I have done with this much work.

And I have one question only were the 3 instances that are as follows :

{% data reusables.profile.access_profile %}
{% data reusables.profile.access_org %}
{% data reusables.organizations.org_settings %}

​Should be replaced with this right :

{% data reusables.profile.access_org %}
{% data reusables.organizations.org_settings %}

And if I get something like this should I replace those 3 from here too??

githubchanges.PNG

@janiceilene
Copy link
Contributor

@StarTrooper08 That's exactly right! If you get a big list that starts with the three reusables

{% data reusables.profile.access_profile %}
{% data reusables.profile.access_org %}
{% data reusables.organizations.org_settings %}

you should replace the three reusables with the two updated ones

{% data reusables.profile.access_org %}
{% data reusables.organizations.org_settings %}

and leave everything else in the list as it is. Thank you for continuing to work on this PR 🎉

@StarTrooper08
Copy link
Contributor Author

Okay👍

@06Den

This comment has been minimized.

@06Den

This comment has been minimized.

@lee-dohm
Copy link
Contributor

It looks like this was made obsolete by #5538, so I'm going to close it. If I've misunderstood, please let me know!

@lee-dohm lee-dohm closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants