-
Notifications
You must be signed in to change notification settings - Fork 64.3k
updated reusable variables #4482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
changes made for issue no github#2919
This comment has been minimized.
This comment has been minimized.
|
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
|
@janiceilene where I will get those |
|
@StarTrooper08 You can find an example of the three of them together here: What we need for you to do is to find all instances of this pattern in the entire project and change it to the second pattern as described in this comment. The most efficient way to do that is to make the changes with a text editor on your local computer rather than through the GitHub website. If you're unfamiliar with how to perform this task in your text editor, you'l have to consult your editor's documentation, specifically "Find in Files" or "Find in Project" is what the feature is typically called in most editors. I hope that helps! |
|
Thanks ,I should start working on it now. |
|
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
|
@janiceilene I have done with few changes for instances mentioned. Work is in progress. |
|
Awesome @StarTrooper08! Thanks for the update 🎉 |
|
So far I have done with this much work. And I have one question only were the 3 instances that are as follows : Should be replaced with this right : {% data reusables.profile.access_org %} And if I get something like this should I replace those 3 from here too?? |
|
@StarTrooper08 That's exactly right! If you get a big list that starts with the three reusables you should replace the three reusables with the two updated ones and leave everything else in the list as it is. Thank you for continuing to work on this PR 🎉 |
|
Okay👍 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It looks like this was made obsolete by #5538, so I'm going to close it. If I've misunderstood, please let me know! |
changes made for issue no #2919
Why:
Closes [issue link]
What's being changed:
Check off the following: