change yaml tutorial link to learnxinyminutes#4695
Merged
skedwards88 merged 4 commits intogithub:mainfrom Mar 25, 2021
Merged
Conversation
Why? 1) mainly because codeproject's yaml tutorial page is littered with <br /> in examples and it's imho confusing especially for beginners (who are target audience) 2) https://learnxinyminutes.com/docs/yaml/ is imho easier to read 3) codeproject uses https://en.wikipedia.org/wiki/Code_Project_Open_License which needs author's consent to use it
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@michalbcz Thanks so much for opening a PR! I'll get this triaged for review 💖 |
janiceilene
added
actions
skedwards88
approved these changes
Mar 23, 2021
Contributor
skedwards88
left a comment
skedwards88
left a comment
There was a problem hiding this comment.
Thank you for this addition! I'll get this merged down for you.
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
<br />in examples and it's imho confusing especially for beginners (who are target audience)What's being changed:
link to external page
Check off the following: