Skip to content

indentation mistake#4773

Merged
lucascosti merged 4 commits intogithub:mainfrom
YSSVR:patch-1
Mar 29, 2021
Merged

indentation mistake#4773
lucascosti merged 4 commits intogithub:mainfrom
YSSVR:patch-1

Conversation

@YSSVR
Copy link
Copy Markdown
Contributor

@YSSVR YSSVR commented Mar 24, 2021

commit-some.png is properly aligned after correcting indentation of stashed change section

Why:Indentation mistake

Closes [issue link]

What's being changed: Indentation courses change in the alignment of the .png in next lines.

Check off the following:

commit-some.png is properly aligned after correcting indentation of stashed change section
@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 24, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR @YSSVR! When I look at your updates on staging versus the site the indentation looks the same.

What change were you hoping to make? When I look at it, I think stashed-changes.png is indented correctly, but commit-all.png is wonky with one word from the bullet rendering after the image. It'll probably take some messing around with the markdown to make that fix, though.

@janiceilene janiceilene added desktop Content related to GitHub Desktop waiting for review Issue/PR is waiting for a writer's review labels Mar 25, 2021
@lucascosti lucascosti self-assigned this Mar 29, 2021
Copy link
Copy Markdown
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @YSSVR!

Yep the indentation was one problem, but there was also another in that the images weren't spaced out from their preceding paragraphs. It should look a lot better now. 👍

I'll get this merged!

@lucascosti lucascosti merged commit 7427a6d into github:main Mar 29, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@1SatoshiNakamoto

This comment has been minimized.

@1SatoshiNakamoto

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Content related to GitHub Desktop waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants