Update www-and-apex-domain-recommendation.md#4956
Merged
lucascosti merged 3 commits intogithub:mainfrom Apr 1, 2021
Merged
Conversation
github-actions
Bot
added
the
triage
tmetz
previously requested changes
Mar 31, 2021
| @@ -1 +1 @@ | |||
| If you are using an apex domain as your custom domain, we recommend also setting up a `www` subdomain. If you configure the correct records for each domain type through your DNS provider, {% data variables.product.prodname_pages %} will automatically create redirects between the domains. For example, if you configure `www.example.com` as your custom domain for your site, and you have `ALIAS` and `CNAME` records set up for the apex and `www` domains, then `example.com` will redirect to `www.example.com`. For more information, see "[Managing a custom domain for your {% data variables.product.prodname_pages %} site](/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site/#configuring-a-subdomain)." | |||
| If you are using an apex domain as your custom domain, we recommend also setting up a `www` subdomain. If you configure the correct records for each domain type through your DNS provider, {% data variables.product.prodname_pages %} will automatically create redirects between the domains. For example, if you configure `www.example.com` as your custom domain for your site, and you have `ALIAS` (alternatively `ANAME` or `A` records) and `CNAME` records set up for the apex and `www` domains, then `example.com` will redirect to `www.example.com`. Note that this is only the case for the `www` subdomains. Automatic redirects are not created for subdomains like e.g `blog`. For more information, see "[Managing a custom domain for your {% data variables.product.prodname_pages %} site](/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site/#configuring-a-subdomain)." | |||
Contributor
There was a problem hiding this comment.
Suggested change
| If you are using an apex domain as your custom domain, we recommend also setting up a `www` subdomain. If you configure the correct records for each domain type through your DNS provider, {% data variables.product.prodname_pages %} will automatically create redirects between the domains. For example, if you configure `www.example.com` as your custom domain for your site, and you have `ALIAS` (alternatively `ANAME` or `A` records) and `CNAME` records set up for the apex and `www` domains, then `example.com` will redirect to `www.example.com`. Note that this is only the case for the `www` subdomains. Automatic redirects are not created for subdomains like e.g `blog`. For more information, see "[Managing a custom domain for your {% data variables.product.prodname_pages %} site](/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site/#configuring-a-subdomain)." | |
| If you are using an apex domain as your custom domain, we recommend also setting up a `www` subdomain. If you configure the correct records for each domain type through your DNS provider, {% data variables.product.prodname_pages %} will automatically create redirects between the domains. For example, if you configure `www.example.com` as your custom domain for your site, and you have `ALIAS` (alternatively `ANAME` or `A` records) and `CNAME` records set up for the apex and `www` domains, then `example.com` will redirect to `www.example.com`. Note that this is only the case for the `www` subdomains. Automatic redirects are not created for subdomains such as, e.g., `blog`. For more information, see "[Managing a custom domain for your {% data variables.product.prodname_pages %} site](/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site/#configuring-a-subdomain)." |
Contributor
Author
There was a problem hiding this comment.
alright, that's better yes!
Contributor
|
@JOJ0 Thanks so much for opening a PR! I'll get this triaged for review 💖 |
janiceilene
added
pages
Contributor
|
🤔 One test seems to be stuck, so I'm to close and reopen this PR to unstick it... |
auto-merge was automatically disabled
April 1, 2021 02:04
Pull request was closed
github-actions
Bot
added
the
triage
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The current docs were misleading to me and I had to ask github support why it doesn't work as expected. Support agent Tammy Metz was very helpful and clarified that actually only the special subdomain www is redirected to the apex domain.
What's being changed:
Trying to clarify that the www subdomain is treated differently compared to subdomains with other names.