Update troubleshooting-custom-domains-and-github-pages.md#4957
Merged
lucascosti merged 3 commits intogithub:mainfrom Apr 1, 2021
Merged
Update troubleshooting-custom-domains-and-github-pages.md#4957lucascosti merged 3 commits intogithub:mainfrom
lucascosti merged 3 commits intogithub:mainfrom
Conversation
github-actions
Bot
added
the
triage
janiceilene
added
pages
Contributor
|
@JOJ0 Thank you so much for opening this PRs 😍 I've triaged this for the team to take a look ✨ |
lucascosti
approved these changes
Apr 1, 2021
Contributor
lucascosti
left a comment
lucascosti
left a comment
There was a problem hiding this comment.
I made a small change, and this is ready to go!
Thanks so much for all these contributions, @JOJ0! 🙇♂️
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Contributor
Author
|
thumbs up and many thanks! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The current docs were misleading to me and I had to ask github support why it doesn't work as expected. Support agent Tammy Metz was very helpful and clarified that actually only the special subdomain www is redirected to the apex domain.
What's being changed:
Clarify that using both apex and custom subdomain is not generally unsupported and redirects between
wwwand apex domain are automatically set up by github.I wrote "If configured correctly" - there should be a link a place where this is explained. Running out of time this moment but could add this later if you point me in the right direction. Thanks in advance!