Skip to content

Updated the environment-variables.md#5139

Merged
lecoursen merged 5 commits intogithub:mainfrom
Sreelayavuyyuru:patch-4
Apr 29, 2021
Merged

Updated the environment-variables.md#5139
lecoursen merged 5 commits intogithub:mainfrom
Sreelayavuyyuru:patch-4

Conversation

@Sreelayavuyyuru
Copy link
Copy Markdown
Contributor

@Sreelayavuyyuru Sreelayavuyyuru commented Apr 7, 2021

Why:

Closes #2693

What's being changed:

I have followed the instructions in the issue to fix this. I have corrected the text in the note box to the mentioned paragraph.
That is,
"When you set a custom environment variable, you cannot use any of the default environment variable names listed above with the prefix GITHUB_. If you attempt to override the value of one of these default environment variables, the assignment is ignored."

I did not remove the Note: (After reviewing the localization checklist) because it was mentioned that the previous one should be change to 'rather a note'.

I am just getting started with open-source so I am sorry if I have done anything that is incorrect.

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 7, 2021
ajsirota
ajsirota previously approved these changes Apr 7, 2021
Copy link
Copy Markdown
Contributor

@ajsirota ajsirota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 👍

@janiceilene
Copy link
Copy Markdown
Contributor

👋 @Sreelayavuyyuru Thank you so much for opening a PR with this fix!

in content/actions/reference/environment-variables.md, change... to a simple paragraph (rather than a note)

From that statement in the issue, I think we do want to remove the {% note %} and {% endnote %} tags. Since this file is a reusable, it's visible in a few different articles and it looks like @hubwriter would prefer it show up in the article as a paragraph, instead of a note.

Let me know when you've removed the tags and I'll get this up for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Apr 9, 2021
@Sreelayavuyyuru Sreelayavuyyuru dismissed stale reviews from ajsirota and ghost via a832643 April 9, 2021 20:22
@Sreelayavuyyuru
Copy link
Copy Markdown
Contributor Author

Hey @janiceilene, Thank you so much for the instructions!
I have removed the tags, so it looks like a paragraph now like you mentioned 👍🏼

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Apr 9, 2021
@lecoursen lecoursen self-assigned this Apr 29, 2021
Copy link
Copy Markdown
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I'll merge it now.

@lecoursen lecoursen enabled auto-merge April 29, 2021 21:23
@lecoursen lecoursen merged commit 495efc0 into github:main Apr 29, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Environment variable docs are inconsistent about GITHUB_ prefix

4 participants