Skip to content

Warn that renaming branches breaks actions#5264

Merged
janiceilene merged 5 commits intogithub:mainfrom
jsoref:warn-about-renaming-action-branches
Apr 30, 2021
Merged

Warn that renaming branches breaks actions#5264
janiceilene merged 5 commits intogithub:mainfrom
jsoref:warn-about-renaming-action-branches

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Apr 11, 2021

Why:

If you rename a branch in a repository that hosts actions, workflows relying on those actions by branch name will break.

Closes [issue link]
image

What's being changed:

Add text to explain this.
Screenshot_20210412-185952

Check off the following:

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 11, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Apr 12, 2021

👋 @jsoref Thanks for opening a PR! Can you add more information to the Why and What's being changed sections of the pull request template in the OP to help ensure this is triaged properly? Let me know when that's done and I'll get this triaged for review ⚡

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Apr 12, 2021

@janiceilene

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 12, 2021
Nirzak
Nirzak previously approved these changes Apr 17, 2021
lecoursen
lecoursen previously approved these changes Apr 29, 2021
Copy link
Copy Markdown
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsoref! I added a suggestion to move the new sentence slightly and use a product name variable, but I'll apply that suggestion and merge now!

Comment thread content/github/administering-a-repository/renaming-a-branch.md Outdated
@lecoursen lecoursen dismissed stale reviews from ghost , Nirzak, and themself via 7c17b5f April 29, 2021 21:28
@lecoursen lecoursen self-assigned this Apr 29, 2021
@lecoursen lecoursen enabled auto-merge April 29, 2021 21:29
@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Apr 29, 2021
@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Apr 29, 2021
@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Apr 29, 2021

@lecoursen: can you please make this stop? (i.e. please send feedback to someone who will listen that they are dissuasive wrt external contributions)

image

It's really confusing and really unhelpful. Speaking as someone who is trying to make contributions to your project. (And many others.) I am now getting regularly haunted by these notifications.

I'm actually quite technical. But whether I wear a non-technical doc writing hat, or a technical code fixing hat, these notifications do not do me any good.

  • They aren't actionable
  • They are all sorts of red, which in normal terms means I should drop what I'm doing and do something to fix them. But I can't.
  • They use a ⚠️ icon which should be 🟡 and paint it 🔴 (specifically 🔺). It's true that drivers may face a red yield icon, but not everyone drives (more importantly, that sign is 🔻), and why in the world would you use that iconography in this context?

@jsoref
Copy link
Copy Markdown
Contributor Author

jsoref commented Apr 29, 2021

Fwiw, it looks like the most actionable action I can take here would be to click the shiny [ Disable auto-merge ] button. Which I'd be tempted to do if it would make the notifications go away.

@janiceilene janiceilene disabled auto-merge April 30, 2021 15:16
@janiceilene janiceilene merged commit a62a1d9 into github:main Apr 30, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@janiceilene
Copy link
Copy Markdown
Contributor

Oh my gosh @jsoref I'm so sorry about all of those notifications! The new "enable workflows" process was fighting with automerge on this one. Hopefully everything we'll get it all smoothed out soon, but in the meantime, I'll get this feedback to the right internal team.

Thank so much for your contribution! We really appreciate you sticking with us through this 💖

@jsoref jsoref deleted the warn-about-renaming-action-branches branch April 30, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants