Skip to content

docs(Creating a GitHub App from a manifest): POST /app-manifests/:code/conversions -> POST /app-manifests/{code}/conversions#5308

Merged
janiceilene merged 1 commit intogithub:mainfrom
gr2m:patch-1
Apr 12, 2021
Merged

Conversation

@gr2m
Copy link
Copy Markdown
Contributor

@gr2m gr2m commented Apr 12, 2021

Why:

I found a left-over route that uses the no longer used :param notation

image

What's being changed:

image

Check off the following:

  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)

…de/conversions` -> `POST /app-manifests/{code}/conversions`
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 12, 2021
Copy link
Copy Markdown
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening a PR with the fix @gr2m! I'll update the branch and get this merged once tests are passing 🍏

@janiceilene janiceilene merged commit d9f3839 into github:main Apr 12, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants