Skip to content

Consistent YAML indentation#5532

Merged
janiceilene merged 3 commits intogithub:mainfrom
hoxu:yaml-indent
Apr 22, 2021
Merged

Consistent YAML indentation#5532
janiceilene merged 3 commits intogithub:mainfrom
hoxu:yaml-indent

Conversation

@hoxu
Copy link
Copy Markdown
Contributor

@hoxu hoxu commented Apr 19, 2021

Why:

YAML indent in the examples is inconsistent. While not strictly unparseable, some tools complain about the indent in the examples.

Closes [issue link]

What's being changed:

Change YAML indent to be consistent and follow YAML spec examples.

Check off the following:

@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 19, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 19, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@janiceilene janiceilene removed the triage Do not begin working on this issue until triaged by the team label Apr 19, 2021
@hoxu
Copy link
Copy Markdown
Contributor Author

hoxu commented Apr 20, 2021

@janiceilene done.

@janiceilene
Copy link
Copy Markdown
Contributor

Thanks so much @hoxu! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review labels Apr 21, 2021
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, @hoxu 😃

We'll get this merged shortly!

@shati-patel shati-patel added the ready to merge This pull request is ready to merge label Apr 22, 2021
@github-actions github-actions Bot removed the waiting for review Issue/PR is waiting for a writer's review label Apr 22, 2021
@janiceilene janiceilene merged commit 5f3079e into github:main Apr 22, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants