eval command standardised across OSes #6994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
Contributor
|
@fluesvamp Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
janiceilene
added
ssh
Author
|
The result of this PR is that there is no longer any question as to whether the eval command should be different on Windows. |
lee-dohm
approved these changes
Jun 4, 2021
Contributor
lee-dohm
left a comment
lee-dohm
left a comment
There was a problem hiding this comment.
Looks good to me, thanks so much! 💖
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Let's unify the command for starting the ssh-agent in "Generating a new SSH key and adding it to the ssh-agent" across OSes.
#6642
What's being changed:
Windows eval command to start ssh-agent.