Skip to content

Add CODEOWNERS usage details#7784

Merged
felicitymay merged 9 commits intogithub:mainfrom
deadletterq:main
Jul 16, 2021
Merged

Add CODEOWNERS usage details#7784
felicitymay merged 9 commits intogithub:mainfrom
deadletterq:main

Conversation

@deadletterq
Copy link
Copy Markdown
Contributor

@deadletterq deadletterq commented Jun 29, 2021 •
edited
Loading

Why:

Closes #7783

What's being changed:

  • Usage of @ghost to exclude directories
  • Changing files under an author's ownership
  • Appointing more than one CODEOWNER

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@deadletterq
Add CODEOWNERS usage details
dfbf11e 
- Usage of @ghost to exclude directories
- Changing files under an author's ownership
- Appointing more than one CODEOWNER
@welcome
Copy link
Copy Markdown

welcome bot commented Jun 29, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 29, 2021
@github github deleted a comment Jun 29, 2021
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Jun 29, 2021

@sidletsky Thanks so much for opening an issue and a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 29, 2021
@felicitymay
Copy link
Copy Markdown
Contributor

felicitymay commented Jul 13, 2021

Thanks for this pull request ✨

I've asked a few questions about these changes on #7783 and will review the pull request once we are clear on what changes to make to this article.

@janiceilene janiceilene added the more-information-needed More information is needed to complete review label Jul 15, 2021
felicitymay
felicitymay reviewed Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sidletsky - thank you for your updates to this PR 💖

I've suggested some changes, but they're fairly small things. Once I've merged those changes, this should be ready to merge. Thank you so much for taking the time to raise this problem, to discuss the best way to make the behavior clear, and to improve the docs for other users. ✨

Comment thread ...ting-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners.md Outdated
Comment thread ...ting-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners.md Outdated
Comment thread ...ting-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners.md Outdated
@felicitymay
Copy link
Copy Markdown
Contributor

felicitymay commented Jul 16, 2021

👋🏻 I'm not sure if you'll have seen these or not, but just in case.

I have just deleted a couple of comments on your original changes that I wrote but didn't submit. It looked as if they reappeared as part of the review of the current content. Apologies for any confusion.

@felicitymay felicitymay removed the more-information-needed More information is needed to complete review label Jul 16, 2021
@felicitymay felicitymay enabled auto-merge (squash) July 16, 2021 17:59
@felicitymay felicitymay merged commit 3dac8c2 into github:main Jul 16, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@felicitymay felicitymay felicitymay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS usage details

3 participants

@deadletterq @janiceilene @felicitymay