Skip to content

Conversation

@amanjha8100
Copy link
Contributor

Why:

Inconsistent workflow branch language issue suggested the changes after the issue was reviewed by GitHub docs team member.

Closes #7278

What's being changed:

A line in the doc is being changed to the suggested one in the comment of the issue by the team member of GitHub docs.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Jul 4, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 4, 2021
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanjha8100 Thank you for opening this PR 😄 I will merge the changes once the tests are passed ⚡

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 6, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Jul 6, 2021
@ramyaparimi ramyaparimi merged commit 58fbe4b into github:main Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@amanjha8100
Copy link
Contributor Author

amanjha8100 commented Jul 6, 2021

Thanks @ramyaparimi for merging the PR. Should I delete the branch?

@ramyaparimi
Copy link
Contributor

@amanjha8100 That would be great 👍

@amanjha8100 amanjha8100 deleted the docs-change branch July 7, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistent workflow branch language

2 participants