Skip to content

Update deploying-to-google-kubernetes-engine.md#8759

Merged
martin389 merged 3 commits intogithub:mainfrom
dmlls:patch-2
Aug 4, 2021
Merged

Update deploying-to-google-kubernetes-engine.md#8759
martin389 merged 3 commits intogithub:mainfrom
dmlls:patch-2

Conversation

@dmlls
Copy link
Copy Markdown
Contributor

@dmlls dmlls commented Aug 3, 2021

Recreating PR for #3488.
The reason can be found here.

Recreating PR for #3488.
The reason can be found [here](#3488 (comment)).
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 3, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@dmlls Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 3, 2021
@martin389 martin389 self-assigned this Aug 4, 2021
@martin389
Copy link
Copy Markdown
Contributor

👋 These changes were previously approved here: #3488 (review)

@martin389
Copy link
Copy Markdown
Contributor

Changes in this PR

(These links will stop working once this PR is merged)

Article in staging Changes
Configuring a service account and storing its credentials Changes to steps 3 and 5.

Tests

All tests are passing! 🍏

@martin389 martin389 merged commit a0f36fb into github:main Aug 4, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@martin389
Copy link
Copy Markdown
Contributor

@dmlls - Thanks again for this PR and helping improve our docs! 🚀 🎉

@dmlls dmlls deleted the patch-2 branch August 4, 2021 08:36
@dmlls
Copy link
Copy Markdown
Contributor Author

dmlls commented Aug 4, 2021

@martin389 thank you all for your attention! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants