Skip to content

chore: Set timeout of 60 minutes for test job#914

Merged
chiedo merged 1 commit intogithub:mainfrom
nschonni:set-test-timeout
Nov 6, 2020
Merged

chore: Set timeout of 60 minutes for test job#914
chiedo merged 1 commit intogithub:mainfrom
nschonni:set-test-timeout

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

@nschonni nschonni commented Oct 29, 2020

Why:

Currently it seems like this job occasionally doesn't finish correctly https://github.com/github/docs/actions?query=is%3Ain_progress and there may be a higher limit set on your org than the default 6 hours

What's being changed:

Set a timeout so the job is failed after 60 minutes (currently seems to run in ~10 minutes)

Check off the following:

@nschonni nschonni requested a review from a team as a code owner October 29, 2020 20:41
Copy link
Copy Markdown
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏼 Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Nov 6, 2020
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Nov 6, 2020

@chiedo could you remove the stale label if you don't have a chance to review right now 😄

@heiskr heiskr removed the stale There is no recent activity on this issue or pull request label Nov 6, 2020
@chiedo chiedo merged commit 346b1b0 into github:main Nov 6, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@chiedo
Copy link
Copy Markdown
Contributor

chiedo commented Nov 6, 2020

Thanks for the ping! I missed this one!

@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Nov 6, 2020

No worries, don't think it got triaged officially yet. I don't want to always ping you, but you seem to be the expert for these 😄

@nschonni nschonni deleted the set-test-timeout branch November 6, 2020 17:30
@janiceilene
Copy link
Copy Markdown
Contributor

@nschonni That was my triaging miss! Sorry about that 💛

@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Nov 6, 2020

@janiceilene no worries, you've got a bunch of stuff incoming here ❤️

@chiedo
Copy link
Copy Markdown
Contributor

chiedo commented Nov 7, 2020

...you seem to be the expert...

Now those are good words to hear before the weekend 👌🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants