Skip to content

Test: add URL to re2 rubygems.org page to assert #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattyoho merged 1 commit into from
Jan 25, 2019
Merged

Test: add URL to re2 rubygems.org page to assert #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/email_reply_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def test_mulitple_on
def test_pathological_emails
t0 = Time.now
email("pathological")
assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem."
assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem. See https://rubygems.org/gems/re2"
Copy link
Copy Markdown
Contributor

@mattyoho mattyoho Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly tweaking the error message language:

Suggested change
assert (Time.now - t0) < 1, "Took too long, upgrade to re2 gem. See https://rubygems.org/gems/re2"
assert (Time.now - t0) < 1, "Parsing took too long, please install the re2 gem locally. See https://rubygems.org/gems/re2"

Copy link
Copy Markdown
Contributor

@mattyoho mattyoho Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, maintainers aren't able to edit the upstream. 🙂Accepting as-is. 👍

end

def test_doesnt_remove_signature_delimiter_in_mid_line
Expand Down