Add image-has-alt and better documentation of rules
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add img alt rule.
bolonio
reviewed
Nov 23, 2021
|
|
||
| ## Rule Details | ||
|
|
||
| `<img>` should have an alt prop with meaningful text or an empty string for decorative images. |
There was a problem hiding this comment.
Shouldn't be must instead of should? (same for all instances). Other than that, looks good to me :)
Collaborator
Author
There was a problem hiding this comment.
must does come off a bit stronger but I think both are ok :)
bolonio
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Changes
GitHub::Accessibility::ImageHasAlt. When enabled, this rule will raise a lint error if animgtag is found without analtattribute set. Thealtattribute must be set to an empty string if the image is decorative, or a string that describes either the image, or the functional use.