Skip to content

Update no-title-attribute-counter.md #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2022
Merged

Update no-title-attribute-counter.md #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions docs/rules/accessibility/no-title-attribute-counter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,14 @@ Use a `<title>` element instead of the `title` attribute, or an `aria-label`.
### **Correct** code for this rule 👍

```erb
<a href="github.com" aria-describedby="description">GitHub</a>
<p id="description" class="tooltip js-tooltip">A home for all developers</p>
<a href="github.com">GitHub</a>
Copy link
Collaborator Author

@khiga8 khiga8 May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swapped the example order

```

**For [Primer ViewComponent](https://primer.style/view-components/) consumers only**:

```erb
<a href="github.com">GitHub</a>
<%= render(Primer::LinkComponent.new(href: "github.com", id: "link-with-tooltip")) do |c| %>
<% c.tooltip(text: "A home for all developers") %>
GitHub
<% end %>
```