Skip to content

Conversation

@khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Jun 10, 2022

Updating our dev dependencies to silence security/dependabot.

This includes a Rubocop version bump so subsequently, some files have changed to address Rubocop lint violations.

@khiga8 khiga8 marked this pull request as ready for review June 10, 2022 23:53
@khiga8 khiga8 requested a review from a team as a code owner June 10, 2022 23:53
@khiga8 khiga8 requested review from bolonio and owenniblock June 10, 2022 23:53

MESSAGE = "<iframe> with meaningful content should have a title attribute that identifies the content."\
" If <iframe> has no meaningful content, hide it from assistive technology with `aria-hidden='true'`."\
" If <iframe> has no meaningful content, hide it from assistive technology with `aria-hidden='true'`."\
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we wrap the <iframe> tag in ` quotes?

@khiga8 khiga8 merged commit 8e14106 into main Jun 15, 2022
@khiga8 khiga8 deleted the kh-dev-dependencies branch June 15, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants