rule: no-aria-hidden-on-focusable-elements #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
#54 must be merged first. |
khiga8
force-pushed
the
kh-no-aria-hidden-on-focusable
branch
from
3e668c3 to
bd16afd
Compare
|
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
smockle
reviewed
Feb 2, 2023
lib/erblint-github/linters/github/accessibility/no_aria_hidden_on_focusable_counter.rb
Show resolved
Hide resolved
khiga8
force-pushed
the
kh-no-aria-hidden-on-focusable
branch
from
9f1b481 to
abde068
Compare
smockle
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new accessibility rule will flag when a focusable element has
aria-hidden="true"set. Why? One might setaria-hidden="true"to hide an element from assistive technologies, but if the element is still reachable by keyboard, it can cause confusion.This is the ERB Lint equivalent of a similar rule I PR-ed to
eslint-plugin-jsx-a11y.