refactor(cli-workflow): unexport internal-only interfaces by Copilot · Pull Request #2436 · github/gh-aw-firewall

Copilot · 2026-05-03T13:54:25Z

WorkflowCallbacks, WorkflowLogger, and WorkflowOptions were exported from src/cli-workflow.ts but never imported elsewhere — making them accidental public API surface.

Changes

src/cli-workflow.ts: Drop export from all three interfaces; they remain in scope for runMainWorkflow within the same module.

// before
export interface WorkflowCallbacks { … }
export interface WorkflowLogger { … }
export interface WorkflowOptions extends WorkflowCallbacks { … }

// after
interface WorkflowCallbacks { … }
interface WorkflowLogger { … }
interface WorkflowOptions extends WorkflowCallbacks { … }

WorkflowDependencies and runMainWorkflow retain their exports as they are part of the intended public surface.

github-actions · 2026-05-03T23:00:20Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	85.76%	85.84%	📈 +0.08%
Statements	85.64%	85.72%	📈 +0.08%
Functions	88.11%	88.11%	➡️ +0.00%
Branches	78.65%	78.69%	📈 +0.04%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/docker-manager.ts`	87.4% → 87.7% (+0.29%)	87.0% → 87.3% (+0.27%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

Pull request overview

Reduces the accidental public TypeScript API surface of the CLI workflow module by making internal-only interfaces module-private, while keeping the intended public exports intact.

Changes:

Unexports WorkflowCallbacks, WorkflowLogger, and WorkflowOptions in src/cli-workflow.ts.
Keeps WorkflowDependencies and runMainWorkflow exported as the intended external surface.

Show a summary per file

File	Description
src/cli-workflow.ts	Makes three internal interfaces non-exported to avoid exposing them as public API/types.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1

+interface WorkflowCallbacks {
  onHostIptablesSetup?: () => void;
  onContainersStarted?: () => void;
 }

-export interface WorkflowLogger {
+interface WorkflowLogger {
  info: (message: string, ...args: unknown[]) => void;
  success: (message: string, ...args: unknown[]) => void;
  warn: (message: string, ...args: unknown[]) => void;
 }

-export interface WorkflowOptions extends WorkflowCallbacks {
+interface WorkflowOptions extends WorkflowCallbacks {
  logger: WorkflowLogger;
  performCleanup: () => Promise<void>;
 }


github-actions · 2026-05-03T23:02:25Z

🔥 Smoke Test Results

Test	Status
GitHub MCP	✅ PR listed successfully
GitHub.com connectivity	✅ HTTP 200/301
File write/read	✅ File exists and readable

Overall: PASS

PR: refactor(cli-workflow): unexport internal-only interfaces — author @Copilot, assignees @lpcox @Copilot

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-05-03T23:02:37Z

Smoke Test: Copilot BYOK — PASS ✅

Test	Result
GitHub MCP (list PRs)	✅ PR #2417 "feat: add 4 agentic code quality workflows" returned
GitHub.com connectivity	✅ (pre-step confirmed HTTP 200/301)
File write/read	⚠️ Pre-step template vars not interpolated; file not found at expected path
BYOK inference (this response)	✅

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

PR author: @Copilot — Assignees: @lpcox, @Copilot

Overall: PASS (file test skipped due to missing pre-step data)

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-05-03T23:02:53Z

Smoke Test Results:

✅ GitHub MCP: Retrieved 2 merged PRs (#2417, #2409)
✅ Playwright: Verified GitHub page title contains "GitHub"
✅ File Writing: Created smoke-test-claude-25281159350.txt
✅ Bash: Verified file creation

Status: PASS

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-05-03T23:03:30Z

feat: add 4 agentic code quality workflows
refactor(api-proxy): extract ProviderAdapter abstraction, make core provider-agnostic
GitHub review ✅
Safeinputs GH CLI ❌
Playwright ✅
Tavily search ❌
File write/read ✅
Discussion comment ✅
Build AWF ✅
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-05-03T23:03:58Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ NO
Node.js	v24.14.1	v20.20.2	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environment.

Tested by Smoke Chroot

github-actions · 2026-05-03T23:04:36Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2436 · ● 561.3K · ◷

github-actions · 2026-05-03T23:05:16Z

Smoke Test Results

❌ Redis (host.docker.internal:6379): timeout/no response
❌ PostgreSQL pg_isready (host.docker.internal:5432): no response
❌ PostgreSQL SELECT 1: skipped (pg_isready failed)

Overall: FAIL — service containers unreachable from this environment.

🔌 Service connectivity validated by Smoke Services

lpcox · 2026-05-03T23:12:41Z

@copilot address the review feedback

Copilot · 2026-05-03T23:13:57Z

@copilot address the review feedback

This is safe — @github/agentic-workflow-firewall is a CLI binary, not a library. package.json has no "types" or "exports" field, "main" points to the CLI entry point (dist/cli.js), and there is no src/index.ts barrel. The generated .d.ts files are a build artefact with no declared public surface, so removing these exports from the declaration output doesn't break any downstream consumer.

The reviewer's concern is valid in general, but doesn't apply here. No code change is needed.

Initial plan

df3af37

Copilot AI assigned Copilot and lpcox May 3, 2026

Copilot started work on behalf of lpcox May 3, 2026 13:57 View session

Copilot AI linked an issue May 3, 2026 that may be closed by this pull request

[Export Audit] Unused exported interfaces in src/cli-workflow.ts: WorkflowCallbacks, WorkflowLogger, WorkflowOptions #2420

Closed

refactor(cli-workflow): remove export from internal interfaces

cc73194

Copilot AI changed the title ~~[WIP] Remove unused exported interfaces in src/cli-workflow.ts~~ refactor(cli-workflow): unexport internal-only interfaces May 3, 2026

Copilot finished work on behalf of lpcox May 3, 2026 14:00

Copilot AI requested a review from lpcox May 3, 2026 14:00

lpcox marked this pull request as ready for review May 3, 2026 22:59

lpcox requested a review from Mossaka as a code owner May 3, 2026 22:59

Copilot AI review requested due to automatic review settings May 3, 2026 22:59

Copilot started reviewing on behalf of lpcox May 3, 2026 22:59 View session

Copilot AI reviewed May 3, 2026

View reviewed changes

github-actions Bot added smoke-copilot smoke-copilot-byok labels May 3, 2026

github-actions Bot added the smoke-claude label May 3, 2026

github-actions Bot added the build-test label May 3, 2026

Copilot started work on behalf of lpcox May 3, 2026 23:12 View session

Copilot finished work on behalf of lpcox May 3, 2026 23:14

lpcox merged commit 0932ace into main May 3, 2026
65 of 74 checks passed

lpcox deleted the copilot/remove-unused-exported-interfaces branch May 3, 2026 23:16

This was referenced May 3, 2026

refactor: deduplicate logs-stats/logs-summary pipeline and test scaffolding #2433

Merged

Mark DockerService and DockerNetwork interfaces as @internal #2439

Merged

Remove unused export from SslBumpConfig in security-critical module #2438

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(cli-workflow): unexport internal-only interfaces#2436

refactor(cli-workflow): unexport internal-only interfaces#2436
lpcox merged 2 commits intomainfrom
copilot/remove-unused-exported-interfaces

Copilot AI commented May 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

lpcox commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions Bot commented May 3, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

github-actions Bot commented May 3, 2026

🔥 Smoke Test Results

Uh oh!

github-actions Bot commented May 3, 2026

Smoke Test: Copilot BYOK — PASS ✅

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented May 3, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented May 3, 2026

Smoke Test Results

Uh oh!

lpcox commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 3, 2026 •

edited

Loading