refactor: remove unused exports from internal modules by lpcox · Pull Request #2465 · github/gh-aw-firewall

lpcox · 2026-05-04T00:11:24Z

Summary

Removes the export keyword from symbols that are never imported outside their defining module. This reduces the public API surface and makes it clear which symbols are internal implementation details.

Changes

File	Symbols de-exported
`src/domain-patterns.ts`	`DomainProtocol`, `ParsedDomain`, `ParsedDomainList`
`src/cli.ts`	`AgentImageResult`, `ApiProxyValidationResult`, `FlagValidationResult`, `LocalhostProcessingResult`
`src/pid-tracker.ts`	`NetTcpEntry`
`src/commands/logs-stats.ts`	`StatsFormat`
`src/commands/logs-summary.ts`	`SummaryFormat`
`src/commands/logs-command-helpers.ts`	`LoggingOptions`
`src/commands/logs.ts`	`LogsCommandOptions`
`src/logs/log-streamer.ts`	`StreamOptions`
`src/logs/index.ts`	Removed `StreamOptions` re-export
`src/config-file.ts`	`AwfFileConfig`
`src/image-tag.ts`	`ImageDigestKey`, `ParsedImageTag`
`src/rules.ts`	`Rule`
`src/docker-manager.ts`	`SslConfig`

Verification

All unit tests pass (domain-patterns, config-file, pid-tracker, cli, image-tag, rules, logs subsystem)
Build succeeds (only pre-existing squid-config.ts type errors remain)
Lint passes with no new errors

Notes

Some symbols from the original issues (#2458, #2459, #2460, #2461) were found to be imported by test files or other source modules upon verification, so they were intentionally kept exported. Only truly unused symbols were de-exported.

Closes #2448, closes #2449, closes #2452, closes #2457, closes #2458, closes #2459, closes #2460, closes #2461

Remove export keyword from symbols that are never imported outside their defining module (including tests). This reduces the public API surface and clarifies which symbols are internal implementation details. Symbols de-exported: - domain-patterns.ts: DomainProtocol, ParsedDomain, ParsedDomainList - cli.ts: AgentImageResult, ApiProxyValidationResult, FlagValidationResult, LocalhostProcessingResult - pid-tracker.ts: NetTcpEntry - logs-stats.ts: StatsFormat - logs-summary.ts: SummaryFormat - logs-command-helpers.ts: LoggingOptions - commands/logs.ts: LogsCommandOptions - logs/log-streamer.ts: StreamOptions - logs/index.ts: removed StreamOptions re-export - config-file.ts: AwfFileConfig - image-tag.ts: ImageDigestKey, ParsedImageTag - rules.ts: Rule - docker-manager.ts: SslConfig Closes #2448, closes #2449, closes #2452, closes #2457, closes #2458, closes #2459, closes #2460, closes #2461 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-05-04T00:12:25Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	85.72%	85.81%	📈 +0.09%
Statements	85.67%	85.75%	📈 +0.08%
Functions	88.31%	88.31%	➡️ +0.00%
Branches	78.70%	78.74%	📈 +0.04%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/docker-manager.ts`	87.3% → 87.6% (+0.29%)	87.1% → 87.4% (+0.28%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

Pull request overview

This PR narrows the TypeScript export surface across several src/ modules by removing export from types that appear to be unused within the repository. In this codebase, those declarations are still part of the published npm/package declaration surface, so the change fits the broader goal of API cleanup but also changes externally visible type exports.

Changes:

Removed export from internal-looking interfaces/type aliases across CLI, logs, config, image-tag, domain, rules, pid-tracker, and docker-manager modules.
Removed the StreamOptions barrel re-export from src/logs/index.ts.
Added unrelated paper/cache artifacts (scripts/paper/...png, paper-data/*.json) that do not match the stated scope of the refactor.

Show a summary per file

File	Description
`src/rules.ts`	De-exports `Rule`.
`src/pid-tracker.ts`	De-exports `NetTcpEntry`.
`src/logs/log-streamer.ts`	De-exports `StreamOptions`.
`src/logs/index.ts`	Removes `StreamOptions` barrel re-export.
`src/image-tag.ts`	De-exports `ImageDigestKey` and `ParsedImageTag`.
`src/domain-patterns.ts`	De-exports domain-related internal types.
`src/docker-manager.ts`	De-exports `SslConfig`.
`src/config-file.ts`	De-exports `AwfFileConfig`.
`src/commands/logs.ts`	De-exports `LogsCommandOptions`.
`src/commands/logs-summary.ts`	De-exports `SummaryFormat`.
`src/commands/logs-stats.ts`	De-exports `StatsFormat`.
`src/commands/logs-command-helpers.ts`	De-exports `LoggingOptions`.
`src/cli.ts`	De-exports several CLI result interfaces.
`scripts/paper/token-savings-firewall-v2.png`	Adds an unrelated paper image asset.
`paper-data/.skip-cache.json`	Adds workflow/cache state unrelated to the refactor.
`paper-data/.gh-aw-skip-cache.json`	Adds additional workflow/cache state unrelated to the refactor.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (4)

src/domain-patterns.ts:246

ParsedDomainList is also part of the published declaration surface today. Making it private will break downstream TypeScript code that imports the interface from this module, so this needs the same breaking-change treatment as any other API removal.

interface ParsedDomainList {

src/cli.ts:267

This de-export removes ApiProxyValidationResult from the published .d.ts for cli. Because consumers can import package subpaths directly, that is an external API break.

interface ApiProxyValidationResult {

src/cli.ts:735

FlagValidationResult is currently visible in the emitted declarations for this module. Making it private will break downstream TypeScript imports, so it should be versioned and documented as a public API change.

interface FlagValidationResult {

src/cli.ts:1008

Removing export here also removes LocalhostProcessingResult from the published type surface of cli. That is a semver-significant API removal, not just internal cleanup.

interface LocalhostProcessingResult {

Files reviewed: 15/17 changed files
Comments generated: 15

@@ -0,0 +1 @@
+[25218590968,25214713163,25195690726,25169444119,25166679387,25115822390,25110488660,25083525437,25077409936,25060888330,25059403794,25057365233,25054228955,25007137215,25005637776,25004516970,25003850826,24979661785,24972169589,24971569188,24942028709,24941991388,24940470947,24918194957,24914910431,24906816554,24878590469,24877755525,24877528111,24877367290,24876534769,24872748804,24871936511,24867999579,24863772584,24850357730,24848508109,24847332347,24842623686,24834303901,24814208321,24753480069,24751171609,24750256355,24748853467,24748632546,24741076636,24696048072,24693917117,24693738874,24693378751,24693187579,24692805251,24691126090,24690933183,24690740033,24690425121,24688419444,24688165459,24687095846,24684649486,24684043315,24682053955,24680602687,24678902591,22081207723,22081206172,22081204783,22081203770,22073943854,22073313985,22038526158,22024160002,22023873008,22023695805,22023595982,22023001987,22022287127,22022178466,22021922120,22021822355,21612810973,21601359528,21092351629,21092351020,21092350359,21092342363,21092325392,21092325208,21092324590,21092323994,21092323690,21092323180,21092322740,21092322282,21092322061,21092321588,21092320846,21092320297,21092319891,21092319606,21092319043,21092318777,21092318202,21092317985,21092317611,21092317217,21092316090,21092315620,21092298627,21092173739,21092123918,21092114147,21092112399,21092110651,21092109890,21092109614,21092109358,21092107564,21092106151,21092104014,21092103920,21092103516,21092103204,21092102995,21092103125,21092102944,21092098665,21092098437,21092098354,21092098235,21092097244,21092097256,21092096084,21092096080,21092096154,21092096305,21092096191,21092095873,21092095958,21092095803,21092095951,22035666588,21969640400,21882151221,21769608802,21734412183,21731599996,21727792783,21647029829,21612811011,21612181835,21601359509,21589943410,21573575150,21562751088,21553817501,24014449080,24013019401,24012506000,24001427244,23991182925,23982295396,23981897254,23981761207,23981516343,23981507991,23978793777,23966647842,23965814010,23965588324,23965257130,23964770782,23964113482,23962697838,23957630066,23935548934,23928909139,23925961940,23925696397,23925394145,23924817288,23919740341,23919645794,23919398574,23918299929,23917325442,23916961994,23916622107,23915369631,23911242767,23908898227,23908548855,23900593981,23882382732,23882121383,23881935565,23878258933,23877180941,23876202475,23874305630,23873101538,23872168561,23867957427,23866922726,23866856379,23862883302,23862098126,23861597321,23861249913,23860683072,23859837937,23857526471,23848854667,23833495690,23830751963,23829922192,23828975666,23827810077,23826782069,23825943802,23825478676,23824680063,23823419275,23819484656,23811674283,23810579965,23810570029,23809499152,23797519150,23781561317,23779285487,23775213965,23744945085,23725710545,23723407638,23716773060,23716653927,23713730329,23713266304,23712406260,23708946485,23698148564,23690297380,23688803209,23688357079,23685123210,23673681851,23646180512,23625665167,23616504488,23615672892,23594534621,23572011407,23568297618,23568015741,23566178485,23565351730,23564909334,23564569294,23564291956,23560627501,23560261673,23553272110,23541074645,23519521997,23512312399,23489542057,23467570735,23454976202,23454015165,23453333351,23447290664,23444610776,23437381102,23416796935,23402939307,23392485621,23379558706,23368324193,23355713275,23342690057,23324160450,23321225306,23319964293,23312074359,23311291777,23311114132,23294768326,23274444473,23262912561,23244830615,23223696569,23216067932,23208183337,23208130392,23208107287,23194277559,23180056361,23178913115,23173062685,23143805802,23123498103,23110271373,23100140343,23097588169,23097349962,23097147923,23095782240,23087842560,23076458777,23060732601,23056869172,23050689064,23035379283,23034667799,23034463242,23034442945,23033826912,23033612439,23033448656,23033264274,23032905585,23032805918,23032289048,23032273047,23032094376,23031879462,23031733633,23031566901,23031227978,23031013709,23030944668,23030632965,23030523849,23030235947,23030123204,23030045623,23029774287,23029654337,23029571843,23029427035,23029271147,23028773447,23028546935,23028383762,23026407930,23025933745,23024618852,23023824896,23022670640,23022503430,23022188520,23022151504,23021896281,23021761354,23021614864,23021568001,23021299875,23018810733,23018665691,23018464762,23018270821,23018025655,23017900375,23017716351,23015440360,23015283045,23015270244,23005850164,23001829217,22985307632,22985143129,22984713100,22982054129,22981409877,22980663938,22970800385,22970656086,22970267295,22970074430,22969603660,22969587337,22969585860,22969580964,22969561717,22969455364,22968955590,22968816768,22968551101,22968393694,22968247277,22967971475,22967766475,22967427678,22966932922,22966761046,22966572547,22965779024,22965562364,22965137188,22964980573,22964820570,22964704136,22952464434,22932379687,22932264181,22932163743,22932059969,22931934007,22931851492,22931715733,22931580189,22931436719,22931375786,22931275774,22931199515,22931193627,22931180174,22931178358,22931175393,22931173347,22931172287,22931035748,22929881374,22929878077,22929874579,22929873933,22929872936,22929870548,22929870267,22929868547,22929866855,22927994987,22926794539,22902370467,22881740407,22853352637,22833881171,22820980703,22810743440,22798948856,22788098221,22763290869,22743818452,22734391352,22734275206,22734171796,22733894287,22733677960,22733315837,22732846824,22732817895,22732758278,22732230982,22732053000,22731901968,22731667996,22731026835,22730613841,22717845769,22696853650,22669207805,22649815372,22642370687,22641181970,22640303986,22639188137,22638961775,22622880716,22603148592,22603140140,22603134440,22602959467,22586901640,22575912998,22560388429,22556974062,22543304004,22532730945,22520632022,22509530851,22508186974,22499024993,22486107791,22470276489,22469225061,22469204757,22469109420,22468322836,22467849591,22467568755,22467422055,22465649023,22458943544,22458884095,22458304275,22457520572,22456872341,22456515721,22456322366,22456223642,22456190838,22452681514,22442076270,22422799111,22419557228,22419545146,22419520869,22419219953,22417997075,22417159077,22416952575,22416790450,22416738899,22416713744,22416501482,22416284515,22416282583,22416069684,22415905165,22415892006,22415860001,22415315431,22415250280,22414574162,22414127367,22414112694,22414057589,22413939440,22413712321,22413323701,22411251036,22411132047,22411068758,22409728925,22409296196,22396879634,22377007707,22376346760,22375090572,22374522331,22373974993,22350831608,22333554485,22331604809,22306110794,22289153973,22277035760,22267565759,22256715523,22247480577,22247167198,22246907419,22223999916,22207731610,22206570775,22203514586,22201432066,22201253646,22200582962,22200520140,22200394499,22181752952,22168649645,22168490404,22167849390,22165363222,22165292343,22164939185,22163959723,22139685956,22121936882,22121318781,22120677770,22120295899,22119567815,22119089449,22118627060,22116851553,22116150672,22115275197,22114892276,22114595759,22098433379,22082080022,22081374967,22081207707,22081206156,22081204814,22080511837,22073943872,22073313981,22062696585,22046438966,22038526166,22035571597,22024159945,22023872982,22023695815,22023595939,22023001993,22022287105,22022178495,22021922091,22021822377,22021681484,22021514454,22021459602,22021371310,22021142577,22020990616,22020907929,22020698211,22020549650,22020292266,22020126809,22019700430,22019365381,22019142098,22018943847,22018706170,22018519694,22017233830,22007931129,22007696155,22006106407,22005253118,22005014196,22004921814,22004471242,22004086721,21999937203,21999301022,21989781401,21989721563,21988744613,21986751946,21983601530,21983080731,21982222400,21981890332,21981577063,21981113041,21980748229,21980325684,21980052313,21979757018,21979033249,21978791382,21978690173,21978551137,21978456139,21978321033,21978273214,21978261210,21978133311,21977917587,21977789708,21977776603,21977574904,21977466241,21977454947,21977329055,21977243553,21977132319,21977064054,21976652633,21976460095,21976254803,21976161588,21975677700,21975472831,21975262099,21975001276,21974669425,21974237710,21973717775,21973417613,21971662657,21971142992,21970441001,21970337231,21969640314,21969369511,21968429945,21968391246,21968389637,21967863735,21966537305,21966505343,21966346006,21966225287,21965930546,21965543322,21964763915,21964509049,21964106048,21964052931,21963585976,21963442376,21963310166,21962867778,21962766078,21962737265,21962690200,21962659827,21962630565,21962603496,21962594319,21962175423,21962056524,21961945264,21961531948,21961398432,21961291531,21959922856,21959823865,21958327585,21957514742,21954030026,21953261833,21946617661,21939754188,21939064601,21938698683,21937881086,21937400781,21936982008,21936807159,21936294352,21935968806,21935286064,21935267612,21934813738,21934741139,21934695303,21934568457,21934475013,21933879922,21933663331,21933390887,21933277553,21933071672,21932766679,21930931017,21930790436,21929140130,21928865264,21928494248,21928139161,21927373230,21926041120,21925639925,21912929097,21911671053,21905138095,21888481478,21887882285,21886864113,21886284625,21886205763,21885952380,21885925911,21883807565,21883741299,21883651740,21883495137,21882985849,21882673803,21882478550,21882418859,21882394032,21882209553,21882151331,21881980221,21881710471,21881548267,21879411070,21879070219,21878734307,21878728256,21877901892,21877093613,21876677323,21855460598,21855150005,21854832562,21854597713,21854586589,21854575559,21854552118,21854367072,21854249507,21854153182,21854107062,21853923947,21852297069,21847230090,21838280456,21837714728,21837292518,21836642462,21836285211,21836226377,21834573498,21825182769,21816564606,21816493354,21816197798,21816046963,21815994220,21815991165,21771045759,21769918680,21769608792,21768434696,21767994424,21765845049,21760357211,21760072042,21758499023,21750485456,21744636159,21743665454,21743293646,21742638946,21735908743,21735624930,21735579046,21735300031,21734652937,21734617894,21734436724,21734383034,21733736993,21733318407,21732111969,21731596900,21731363117,21730900640,21729338588,21728425179,21728091506,21727792741,21726878021,21726643829,21725387782,21722898246,21711413475,21698153409,21694333791,21691231145,21690990093,21690704996,21690581751,21688655959,21687517583,21686841647,21686572642,21686334419,21686330488,25187288095,25132086608,25076214695,25017464287,24965809985,24939478511,24931277266,24909373636,24856455411,24800355051,24585028323,24049117468,24009454641,23986547955,23960446050,23922339242,23919449375,25211677957,25161504927,25104842239,24954445889,24662423162,24626944774,24602754451,24538516369,24538036653,24394748366,24163121706,23999607726,23977034053,23943294536,23918469472]


 * Result of processing the agent image option
 */
-export interface AgentImageResult {
+interface AgentImageResult {


@@ -0,0 +1 @@
+[25218492192,25218452230,25210481591,25210364737,25204554378,25198959980,25187472028,25187376732,25187315552,25166073346,25165805227,25165780140,25164532229,25146290065,25141990853,25133891850,25130447525,25130446301,25130444074,25130441725,25104995834,25083997739,25079429771,25067217584,25065153620,25062415426,25050303106,25050188949,25047278744,25046563306,25044985895,25038804604,25038772381,25038454477,25036559545,25024215178,25023060039,25010718048,25009032018,24996471598,24993268843,24991408439,24984207380,24983121634,24976470310,24961552638,24961476080,24958131576,24932613723,24921481434,24910112939,24904301365,24901822188,24901751818,24900681996,24898452946,24898351587,24892745674,24888721327,24878954028,24857352629,24857324378,24851875388,24827670390,24827641898,24810445774,24803329493,24795392666,24791757938,24791742313,24791727646,24791210302,24789574210,24780934635,24780883481,24771662959,24769807540,24769611411,24760871784,24760339924,24759722184,24756914888,24752310882,24745806502,24742237866,24741985287,24738593728,24737671671,24722074096,24721121117,24721106512,24720986030,24699993704,24699479276,24689430871,24681803861,24680519544,24652594814,24649050651,24645591861,24645451000,24645419039,24644443270,24644262473,24644203284,24644164331,24644110430,24644059994,24639781268,24579781834,24579500458,24577634294,24576091674,24576070788,24576029355,24575674478,24546744630,24545274086,24532134428,24528406965,24524477317,24513648170,24511903698,24511871298,24508555259,24508502923,24505301728,24494019047,24488842405,24488548369,24475061347,24474310938,24473500864,24473494007,24470434510,24470400397,24464775492,24464725317,24464211628,24464134525,24463803940,24463741304,24461549856,24459506247,24457247707,24452434293,24452434219,24435469623,24432943860,24432897010,24431956828,24431916268,24401831639,24392242746,24391839998,24381400585,24380948843,24380875082,24374768181,24374750362,24374672276,24374654308,24371121752,24365853525,24362940105,24362906570,24355365559,24354949868,24354930084,24354869581,24352271884,24348339922,24347234480,24336547819,24331589197,24321725640,24320142494,24319160231,24319143192,24319108670,24319062227,24318028603,24318017769,24302573713,24302405810,24294553267,24289771604,24289754430,24278271444,24278266528,24278251443,24278235807,24278235761,24278193815,24278174458,24268763026,24268427705,24265366500,24264246400,24257546075,24253182411,24245871127,24243975669,24241898733,24233349515,24225289562,24218700884,24201360557,24195874175,24189612612,24184974515,24177080668,24171170690,24157225005,24151786694,24151273463,24151241667,24151194932,24150492979,24149482158,24148756043,24148469412,24146573552,24138695243,24137194207,24135156790,24112300594,24110430707,24097411271,24096514028,24096122878,24092513428,24091511489,24091459305,24090438670,24052825616,24050548313,24040565632,24039013096,24038686805,24038525375,24037048794,24035392452,24035263309,24034925809,24034762589,24019350081,24005447884,24005445478,24005443487,24002713381,24000627701,23986990905,23986971356,23986935419,23986202995,23986097468,23981079202,23968879938,23966990988,23962985941,23960764773,23960719471,23960668700,23960610580,23959146261,23950551965,23946958597,23946564968,23945117969,23938244803,23937175212,23932323320,23932178482,23932169057,23929630117,23929471860,23928813348,23926469143,23926175223,23916373285,23916279530,23916202362,23911289953,23908251039,23908238484,23905963141,23905683324,23905031404,23903655555,23901948731,23900948007,23891361706,23891351604,23890657769,23888031476,23878975607,23878341143,23877328698,23876221206,23874472487,23872701164,23872686199,23872679398,23870994060,23870775715,23867969584,23865291880,23864974873,23864958873,23862190729,23860173451,23858175943,23855744129,23851143910,23849215724,23836146271,23833353464,23826867543,23819621391,23818811486,23817466755,23817465479,23817440857,23816835866,23816652149,23813811729,23812018248,23811910684,23808559970,23802169575,23801926372,23801675551,23801614557,23800080289,23799852917,23799816684,23799763670,23797909415,23788377648,23784474597,23781365534,23775348697,23775292848,23773168502,23764781983,23764648967,23764445403,23764332208,23760189557,23757102038,23756178887,23748282225,23718481005,23718469227,23718458284,23718446481,23710176450,23664638441,23661256777,23660068824,23636028146,23635945874,23635753259,23626020604,23626012279,23621222216,23610697766,23610691738,23610108703,23607562251,23591762222,23591755677,23591520024,23590071870,23576299040,23574412528,23573647110,23558724120,23556684666,23554971711,23547418299,23547317486,23541684380,23541649586,23519595745,23518652274,23517561053,23517533736,23517451249,23517380081,23512233158,23512216007,23512175161,23511966173,23511753228,23506527450,23505515655,23505489043,23504303110,23498069427,23494238029,23492803671,23490021039,23485820479,23476748150,23472123582,23468981437,23468978097,23467652220,23465730616,23464794777,23461043169,23458432422,23457793525,23456531393,23453639660,23450282556,23438910182,23438879474,23437383031,23433098524,23431287082,23424804848,23422824596,23419407087,23419336193,23419327958,23416798452,23416096781,23410851159,23410491569,23410446637,23409447997,23406580846,23402943030,23397380365,23392486282,23385786584,23383964391,23382312832,23379561410,23375288657,23373838654,23368325601,23358548225,23357078286,23356950507,23355954308,23355764143,23354529624,23350164557,23346757100,23346709863,23346704598,23346142456,23343288461,23343264310,23342691398,23342159710,23332286509,23331826991,23324161117,23323992718,23322579967,23321399785,23319021044,23309897586,23307056271,23306791437,23300953022,23300268135,23300197835,23298671230,23296240042,23296141730,23294770566,23294658585,23294010009,23283701319,23283696448,23282931231,23277885359,23277788355,23275389315,23274723585,23274445786,23273176043,23270602960,23270560852,23263275339,23263228181,23263181185,23263077407,23263069475,23262854694,23262577587,23261028236,23260782479,23260408511,23260201386,23260136681,23259186640,23258882559,23256391970,23247200154,23244830168,23244544269,23243143417,23241996018,23237214152,23232324356,23229207564,23229064526,23228231272,23224389768,23223698035,23220240927,23215585061,23215541906,23215519060,23214572592,23212783552,23210791215,23210244828,23209531142,23206244191,23201069304,23198100859,23194282034,23188239422,23181718726,23179589229,23177647023,23173970073,23173065061,23172778469,23170645148,23170362056,23169582540,23159772340,23158268857,23158254136,23154479079,23154451857,23154111417,23153917749,23148440782,23148408184,23147869902,23147802409,23143809225,23139658203,23138671774,23137952802,23133140944,23131382964,23124991690,23124609617,23124597459,23124591464,23124558346,23123499091,23123356377,23123199378,23122145764,23121346116,23116714952,23116424570,23115264456,23111371468,23111242321,23111108604,23110272273,23105070950,23104037337,23103719776,23101079449,23101055832,23100139843,23098170482,23098162332,23098144794,23098079621,23093767484,23093747455,23093747172,23093743451,23092961107,23090791740,23090761042,23090578047,23090558148,23087843613,23083281793,23082340675,23081103100,23079611836,23078491884,23078478141,23076817660,23076813285,23076460467,23074558467,23071909960,23071864624,23069385665,23064798754,23064590982,23064522892,23059960694,23059686874,23059678935,23057916980,23057871153,23054173216,23051588927,23031015467,23020669926,23020171928,23017680657,23014448332,23010875765,23010453666,23009875040,23005431933,23001831774,23000820953,23000740038,22998267273,22998235300,22998067850,22998038452,22992220174,22989580246,22983419039,22981411232,22975924866,22975205949,22975093104,22974646482,22973152855,22973134032,22972966230,22971362567,22968962584,22968293497,22965222434,22960973328,22959823562,22959724818,22958708693,22958597402,22954214823,22954168208,22954155823,22954143167,22954128115,22954112138,22954025239,22952467110,22944895746,22939921712,22934443901,22931275176,22931173968,22927107686,22922153860,22921071452,22921010855,22920961666,22920951502,22920907518,22920203848,22915487222,22915471701,22915433070,22914921978,22914915568,22910307818,22909805107,22903124320,22902372784,22898465462,22895525357,22890104724,22888720617,22883349836,22881742253,22881351669,22874950485,22874694491,22873019165,22868772762,22868595109,22867418891,22866734870,22866553117,22866545191,22866383251,22866340724,22865772518,22865375696,22860142591,22857152506,22856837847,22856820966,22853355382,22851712800,22847296788,22844994128,22841739239,22841416641,22837973037,22833883347,22831274517,22831267204,22829969870,22827735792,22827035264,22827004608,22826236397,22826141722,22826137288,22825940287,22820983085,22817539177,22815873143,22815606927,22815558587,22815244570,22815242967,22810746261,22810690409,22805848341,22804556516,22804500819,22804409353,22804343699,22804331948,22803156431,22802499310,22802362476,22802313685,22798950697,22793736312,22788100025,22782111445,22776427106,22761872542,22758999530,22757589827,22757584681,22751995174,22751234521,22743821253,22740009033,22738897163,22735351736,22731603981,22723261424,22717848198,22711902983,22710849743,22705635633,22705441781,22704680528,22696854891,22688205254,22686828659,22686816327,22686764965,22683288462,22682417680,22680608879,22680599500,22678670592,22676602769,22676316913,22674452504,22672803297,22672798447,22672788956,22669209520,22661069572,22657875896,22653838321,22653828454,22652204855,22649817824,22648825705,22648808569,22648796917,22648781445,22648137895,22646847965,22646501758,22636471751,22633429431,22624291988,22623942210,22623897320,22617388676,22616148781,22616134506,22615987064,22610191881,22599699652,22594153152,22593606310,22589864532,22578527175,22578123726,22575916225,22572575916,22564749205,22564302837,22559706211,22556975177,22553144954,22551530807,22549816836,22549584159,22547719717,23941001988,23929477388,23912480161,23902283556,23893151557,23885365207,23878910041,23870775977,23861032922,23850560883,23841264122,23833651355,23827210804,23819237486,23810030366,23799315978,23789719794,23782002966,23767680780,23757508268,23746683601,23723828494,23718934852,23714263073,23709868916,23705629496,23702262183,23698455321,23689938775,23685988978,23678256024,23674195540,23667362044,23658343227,23647979795,23639062868,23632568819,23626307544,23617785995,23607984794,23596329233,23586346625,23578971719,23572639130,23554169555,23542944647,23533249744,23526160649,23520207240,23502592746,23491380683,23481568510,23474356987,23468376628,23459937797,23450279267,23439544448,23422828677,23417513843,23407981172,23403839698,23399731561,23396418263,23392989124,23388709170,23384393835,23380456803,23369048213,23344715032,23336162325,23330199047,23325087694,23297029097,23287680376,23281152532,23275325075,23267070010,23257644763,23237287450,23230463715,23224633931,23216466068,23207104501,23196409285,23186765140,23179794131,23174028175,23165997440,23145940865,23136263034,23129426404,23124112291,23119245727,23115051118,23096268928,23092352093,23084836065,23081189627,23077197750,23070430524,23061944613,23031921754,23023801597,23014480655,23004039071,22994436703,22987779781,22982413758,22974309328,22944966728,22937976954,22932153686,22924121873,22914871698,22904522397,22895071998,22888248255,22874647233,22865485869,22855488945,22846134551,22839579301,22834564340,22829752108,22821777251,22817877957,22814552604,22811230747,22807117354,22803222776,22799664448,22796078658,22792673127,22788880515,22781814767,22773706309,22765141392,22756626858,22750157896,22744705163,22736674731,22728673744,22719849368,22710516136,22703506411,22697804672,22689143627,22680339869,22671111466,22662478043,22656132065,22650770428,22642570332,22634240679,22624824499,22615951609,22609461431,22603875009,22595633538,22586971804,22577834565,22568965972,22562510346,22557659254,22552534298,22548119940,22544117864,22540025653,22536688051,22533179549,25202024098,25106195991,25106073962,25106041052,25051354246,25051327349,25021985859,25021768522,25021588096,24910600738,24910407134,24858003099,24857982634,24857959929,24638303135,24613410653,24532177836,24532118501,24398592627,24398274440,24396807140,24365472874,24365467767,24365417697,24263122003,23942998940,23895628233,23843783508,23792325810,23740053995,23535836784,23484216383,23432345784,23338178656,23289935140,23239757575,23189188464,23138776565,22996855551,22947445508,22897468932,22848623630,22758768592,22755652632,22712997696,22664669146,22618215413,22571351455,23943220569,23896296491,23793030457,23485056190,23452446743,23408901007,23385266939,23355803594,23259669513,23158653213,23115934979,23093174954,23063728061,22867449865,22826477042,22804054329,22775428573,22730626989,22682258339,22588857773,23923212586,23872138058,23820648739,23769022209,23513461122,23467543056,23416082553,23391947089,23367704379,23323295781,23273593836,23222769841,23172235630,23122778626,23099535268,23075797398,23030161698,22980615666,22930299334,22880918863,22833213331,22810243361,22787426058,22742916404,22695923024,22648945830,22556305744,22532140910,23943540379,23896619771,23844744375,23793316208,23485415687,23441101546,23386850089,23385216420,23404420733]


 * SSL configuration for Docker Compose (when SSL Bump is enabled)
 */
-export interface SslConfig {
+interface SslConfig {


 * Options for the logs command
 */
-export interface LogsCommandOptions {
+interface LogsCommandOptions {


 * Options for streaming logs
 */
-export interface StreamOptions {
+interface StreamOptions {


  listLogSources,
 } from './log-discovery';
-export { streamLogs, StreamOptions } from './log-streamer';
+export { streamLogs } from './log-streamer';


 import { validateWithSchema } from './schema-validator';

-export interface AwfFileConfig {
+interface AwfFileConfig {


+type ImageDigestKey = typeof IMAGE_DIGEST_KEYS[number];

-export interface ParsedImageTag {
+interface ParsedImageTag {


 * Output format type for summary command (alias for shared type)
 */
-export type SummaryFormat = LogStatsFormat;
+type SummaryFormat = LogStatsFormat;


lpcox · 2026-05-04T00:15:31Z

@copilot address the review feedback

github-actions · 2026-05-04T00:15:48Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	3.12.13	3.12.3	❌
Node.js	v24.14.1	v20.20.2	❌
Go	go1.22.12	go1.22.12	✅

Overall: ❌ Not all versions match. Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

Per review feedback, removing export from types compiled to dist/*.d.ts (no exports map) is a breaking API change for downstream consumers. Restore export on all de-exported symbols and remove the unrelated paper-data JSON and scripts/paper PNG files accidentally included. Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/934b1db5-a5f3-44f6-a314-0f59e77f4e10

Copilot · 2026-05-04T00:18:15Z

@copilot address the review feedback

Done. Addressed all review feedback in commit b5ea8ca:

Restored all export keywords across the 13 affected source files. Since the package has no exports map in package.json, every declaration in src/ is compiled into dist/*.d.ts and is part of the published public API surface. Removing these exports would be a breaking API change, not an internal cleanup.
Removed the 4 unrelated files (paper-data/.skip-cache.json, paper-data/.gh-aw-skip-cache.json, scripts/paper/token-savings-chart-v4.png, scripts/paper/token-savings-firewall-v2.png) that were accidentally included in the PR scope.

All 1731 tests continue to pass.

github-actions · 2026-05-04T00:56:14Z

Smoke Test Results

✅ GitHub MCP: Last 2 merged PRs retrieved
✅ Playwright: GitHub page title verified
✅ File Writing: Test file created successfully
✅ Bash Tool: File verified with cat

Status: PASS

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-05-04T00:57:19Z

Mark DockerService and DockerNetwork interfaces as @internal
Remove unused export from SslBumpConfig in security-critical module
GitHub MCP review ❌ | safeinputs-gh ❌
Playwright ✅ | Tavily ❌
File write ✅ | Bash readback ✅
Discussion comment ✅ | Build AWF ✅
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-05-04T00:58:20Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2465 · ● 424.8K · ◷

github-actions · 2026-05-04T00:58:48Z

Smoke Test Results

Redis PING: ❌ (no response / timeout)
PostgreSQL pg_isready: ❌ (no response)
PostgreSQL SELECT 1: ❌ (skipped — host unreachable)

Overall: FAIL — host.docker.internal services are not reachable from this environment.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-05-04T01:18:59Z

Smoke Test: Copilot BYOK (Offline) Mode — PR by @lpcox, reviewer @Mossaka

Test	Result
GitHub MCP (list PRs)	✅ PR #2465 returned
GitHub.com connectivity	⚠️ template var unexpanded
File write/read	⚠️ template var unexpanded
BYOK inference (api-proxy → api.githubcopilot.com)	✅

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PARTIAL PASS (MCP + BYOK inference ✅; pre-step template vars not expanded in workflow)

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-05-04T12:53:51Z

🔍 Smoke Test Results

Test	Status
GitHub MCP connectivity	✅ PASS
GitHub.com HTTP connectivity	❓ N/A (template vars unresolved)
File write/read	❓ N/A (template vars unresolved)

Overall: PARTIAL — Pre-computed step outputs (steps.smoke-data.outputs.*) were not injected into the prompt. MCP connectivity confirmed working. Tests 2 & 3 could not be verified.

PR: "refactor: remove unused exports from internal modules" — author @lpcox, reviewer @Mossaka.

📰 BREAKING: Report filed by Smoke Copilot

lpcox requested a review from Mossaka as a code owner May 4, 2026 00:11

Copilot AI review requested due to automatic review settings May 4, 2026 00:11

Copilot started reviewing on behalf of lpcox May 4, 2026 00:11 View session