Skip to content

fix: remove unused exported interfaces from services and pid-tracker#2715

Merged
lpcox merged 1 commit intomainfrom
fix/remove-unused-exports-batch2
May 8, 2026
Merged

fix: remove unused exported interfaces from services and pid-tracker#2715
lpcox merged 1 commit intomainfrom
fix/remove-unused-exports-batch2

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented May 8, 2026

Summary

Removes 5 unnecessarily exported interfaces that were only used internally within their own modules.

Changes

  • src/pid-tracker.ts: NetTcpEntry → unexported (used only by parseNetTcp and findInodeForPort internally)
  • src/services/agent-service.ts: AgentServiceParams, IptablesInitServiceParams → unexported
  • src/services/agent-volumes.ts: AgentVolumesParams → unexported
  • src/services/agent-environment.ts: AgentEnvironmentParams → unexported
  • Removed *Params type re-exports from the agent-service barrel

Verification

  • npm run build
  • 181 related tests pass ✅

Closes #2694, closes #2695

- Remove export from NetTcpEntry in src/pid-tracker.ts (internal only)
- Remove export from AgentServiceParams, IptablesInitServiceParams in
  src/services/agent-service.ts
- Remove export from AgentVolumesParams in src/services/agent-volumes.ts
- Remove export from AgentEnvironmentParams in src/services/agent-environment.ts
- Remove re-exports of *Params types from agent-service barrel

These interfaces are only used within their own modules and were
unnecessarily polluting the public API surface.

Closes #2694, closes #2695

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 8, 2026 03:03
@lpcox lpcox requested a review from Mossaka as a code owner May 8, 2026 03:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 87.48% 87.55% 📈 +0.07%
Statements 87.44% 87.51% 📈 +0.07%
Functions 82.66% 82.66% ➡️ +0.00%
Branches 79.65% 79.69% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/container-lifecycle.ts 87.1% → 88.2% (+1.14%) 87.5% → 88.6% (+1.11%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reduces the public TypeScript API surface by removing exports for several interfaces that are only used internally within their defining modules, aligning with the export-audit issues (#2694, #2695).

Changes:

  • Make NetTcpEntry (pid tracker) and several *Params interfaces (agent services) module-internal by removing export.
  • Stop re-exporting AgentEnvironmentParams / AgentVolumesParams from src/services/agent-service.ts, while keeping function re-exports for compatibility.
Show a summary per file
File Description
src/services/agent-volumes.ts Makes AgentVolumesParams internal while keeping buildAgentVolumes exported.
src/services/agent-service.ts Removes exported param interfaces and drops type re-exports; retains function re-exports.
src/services/agent-environment.ts Makes AgentEnvironmentParams internal while keeping buildAgentEnvironment exported.
src/pid-tracker.ts Makes NetTcpEntry internal while keeping parsing/lookup functions exported.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔬 Smoke Test Results

Test Status
GitHub MCP (PR fetch)
File write/read (smoke-test-copilot-25534243635.txt)
GitHub.com connectivity

PR: fix: remove unused exported interfaces from services and pid-tracker
Author: @lpcox | Assignees: @lpcox, @Copilot

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Smoke Test Results

✅ GitHub API: Retrieved last 2 merged PRs

✅ Playwright: github.com page title verified
✅ File Writing: smoke-test-claude-25534243637.txt created
✅ Bash: File contents verified

PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔥 Smoke Test: Copilot BYOK Offline Mode

Test Result
GitHub MCP connectivity
GitHub.com HTTP ⚠️ (template vars unresolved)
File write/read ⚠️ (template vars unresolved)
BYOK inference (this response)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Overall: PARTIAL — BYOK inference and MCP confirmed working; pre-step template outputs were not interpolated.

PR: "fix: remove unused exported interfaces from services and pid-tracker" by @lpcox, reviewers: @Mossaka @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2715 · ● 1.6M ·

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

fix(api-proxy): fetch models from BYOK custom providers and fix models_url in reflect
chore: upgrade agentic workflows to gh-aw v0.71.5
✅ GitHub PR review
❌ Safeinputs GH CLI
✅ Playwright title check
❌ Tavily search
✅ File write/read and build
❌ Discussion safe-input query
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Chroot Smoke Test Results

Runtime Host Version Chroot Version Match?
Python 3.12.13 3.12.3
Node.js 24.14.1 20.20.2
Go 1.22.12 1.22.12

Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Smoke Test Results — PR #2715

Check Result
Redis PING ❌ Timeout (no response)
PostgreSQL pg_isready ❌ No response on port 5432
PostgreSQL SELECT 1 ❌ Timeout/connection failed

Overall: FAILhost.docker.internal is unreachable from this runner environment. Service containers are not accessible.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit 4564c0a into main May 8, 2026
69 of 72 checks passed
@lpcox lpcox deleted the fix/remove-unused-exports-batch2 branch May 8, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants