Skip to content

refactor: delete dead-code duplicate src/types/config.ts#3141

Merged
lpcox merged 2 commits into
mainfrom
copilot/fix-duplicate-code-config-index
May 14, 2026
Merged

refactor: delete dead-code duplicate src/types/config.ts#3141
lpcox merged 2 commits into
mainfrom
copilot/fix-duplicate-code-config-index

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

src/types/config.ts was a 24-line file that re-exported an identical subset of src/types/index.ts. Nothing in the codebase imported from it — the "backward-compatible re-exports" comment notwithstanding.

Changes

  • Deleted src/types/config.ts — entire file was dead code
  • Deleted src/types/config.test.ts — only existed to test the deleted file
  • Updated src/types/docker.ts — was the one internal consumer (relative ./config import missed by the cross-directory grep); now imports UpstreamProxyConfig directly from ./upstream-proxy
// before
import type { UpstreamProxyConfig } from './config';

// after
import type { UpstreamProxyConfig } from './upstream-proxy';

Copilot AI changed the title [WIP] Remove duplicate code between config.ts and index.ts refactor: delete dead-code duplicate src/types/config.ts May 14, 2026
Copilot finished work on behalf of lpcox May 14, 2026 13:40
Copilot AI requested a review from lpcox May 14, 2026 13:40
@lpcox lpcox marked this pull request as ready for review May 14, 2026 13:40
@lpcox lpcox requested a review from Mossaka as a code owner May 14, 2026 13:40
Copilot AI review requested due to automatic review settings May 14, 2026 13:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused duplicate type re-export module and updates the only internal reference to import the upstream proxy type from its source module.

Changes:

  • Deleted src/types/config.ts, which duplicated exports already available through src/types/index.ts.
  • Deleted the test file that only validated the removed re-export module.
  • Updated src/types/docker.ts to import UpstreamProxyConfig directly from ./upstream-proxy.
Show a summary per file
File Description
src/types/docker.ts Replaces the removed ./config import with the direct upstream proxy type import.
src/types/config.ts Removes the duplicate compatibility re-export module.
src/types/config.test.ts Removes tests that only covered the deleted re-export module.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ❌ 401 Bad credentials
GitHub.com HTTP ⚠️ Pre-step data not substituted
File write/read (smoke-test-copilot-byok-25863253373.txt) ✅ File exists and readable
BYOK inference (agent → api-proxy → api.githubcopilot.com) ✅ Response received

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PARTIAL — BYOK inference and file I/O pass; GitHub MCP returned 401 (credential issue in this environment).

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

GitHub API - HTTP 401: Bad credentials (gh CLI auth issue)
Playwright - Successfully navigated to github.com, title contains "GitHub"
File Verify - Smoke test file exists and verified

Total: 2/3 PASSED

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Status
GitHub MCP connectivity ❌ (401 Bad credentials)
GitHub.com HTTP connectivity ❌ (template vars not substituted)
File write/read ❌ (template vars not substituted)

Overall: FAIL

The workflow's pre-step outputs (steps.smoke-data.outputs.*) were not substituted into the task prompt — all three test inputs arrived as literal ${{ }} placeholders. The GitHub MCP server also returned 401 Bad credentials, preventing PR data lookup.

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke test: FAIL
PRs: fix: skip node --version check under QEMU emulation in agent Dockerfile; fix: remove unused public exports and normalize test-only access
✅ GitHub PR review
❌ safeinputs-gh query
✅ Playwright title check
❌ Tavily search
✅ File/bash checks
⚠️ Discussion skipped
✅ Build
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3
Node.js v24.14.1 v20.20.2
Go go1.22.12 go1.22.12

Overall: ❌ Not all versions match — Python and Node.js differ between host and chroot environments.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke test result: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3141 · ● 6.7M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results — FAIL

Check Result
Redis PING ❌ Timeout/no response
PostgreSQL pg_isready ❌ No response on port 5432
PostgreSQL SELECT 1 ❌ Timeout/no response

host.docker.internal is not reachable from this environment. Service containers may not be running or the hostname is not resolvable. Overall: FAIL

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit d726696 into main May 14, 2026
70 of 73 checks passed
@lpcox lpcox deleted the copilot/fix-duplicate-code-config-index branch May 14, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Duplicate Code] src/types/config.ts is a subset duplicate of src/types/index.ts

3 participants