refactor: delete dead-code duplicate src/types/config.ts#3141
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes an unused duplicate type re-export module and updates the only internal reference to import the upstream proxy type from its source module.
Changes:
- Deleted
src/types/config.ts, which duplicated exports already available throughsrc/types/index.ts. - Deleted the test file that only validated the removed re-export module.
- Updated
src/types/docker.tsto importUpstreamProxyConfigdirectly from./upstream-proxy.
Show a summary per file
| File | Description |
|---|---|
src/types/docker.ts |
Replaces the removed ./config import with the direct upstream proxy type import. |
src/types/config.ts |
Removes the duplicate compatibility re-export module. |
src/types/config.test.ts |
Removes tests that only covered the deleted re-export module. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
🔥 Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: PARTIAL — BYOK inference and file I/O pass; GitHub MCP returned 401 (credential issue in this environment).
|
Smoke Test Results❌ GitHub API - HTTP 401: Bad credentials (gh CLI auth issue) Total: 2/3 PASSED
|
🔬 Smoke Test Results
Overall: FAIL
|
|
Smoke test: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Version Comparison Results
Overall: ❌ Not all versions match — Python and Node.js differ between host and chroot environments.
|
|
Smoke test result: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results — FAIL
|
src/types/config.tswas a 24-line file that re-exported an identical subset ofsrc/types/index.ts. Nothing in the codebase imported from it — the "backward-compatible re-exports" comment notwithstanding.Changes
src/types/config.ts— entire file was dead codesrc/types/config.test.ts— only existed to test the deleted filesrc/types/docker.ts— was the one internal consumer (relative./configimport missed by the cross-directory grep); now importsUpstreamProxyConfigdirectly from./upstream-proxy