Remove dead re-export barrel src/types/config.ts#3144
Conversation
src/types/config.ts
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy src/types/config.ts re-export barrel and its dedicated test. The intended cleanup is small, but the deletion currently leaves an internal production import unresolved.
Changes:
- Deleted the backward-compatible
src/types/config.tsbarrel. - Deleted the test that only validated that barrel’s re-exports.
Show a summary per file
| File | Description |
|---|---|
src/types/config.ts |
Removes the legacy config/type re-export barrel. |
src/types/config.test.ts |
Removes tests that only exercised the deleted barrel. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
src/types/config.ts:1
- Deleting this barrel breaks the existing production type import in
src/types/docker.ts(import type { UpstreamProxyConfig } from './config';). Becausetsconfig.jsonincludessrc/**/*, the build will fail with a missing module unless that importer is updated (for example to./upstream-proxy) before removing this file.
- Files reviewed: 2/2 changed files
- Comments generated: 0
|
@copilot fix the failing ci check https://github.com/github/gh-aw-firewall/actions/runs/25863264750/job/75998726653?pr=3144 |
|
🔬 Smoke Test Results
Overall: FAIL — GitHub MCP authentication unavailable in this environment.
|
Smoke Test Results
Result: 2/3 PASS — API test blocked by auth issue
|
Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: FAIL — GitHub MCP returned 401 and pre-step outputs were not injected into the prompt.
|
|
Smoke Codex: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test Results
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Chroot Smoke Test Results
Result: FAILED — Python and Node.js versions differ between host and chroot. Go matches.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results — FAIL
|
src/types/config.tswas a "backward-compatible re-exports" barrel with no production importers — every consumer already resolves tosrc/types/index.ts, which is a strict superset. The file posed a silent divergence risk: new types added toindex.tsrequired a separate decision to mirror inconfig.ts.Changes
src/types/config.ts— dead re-export barrel, never imported by production codesrc/types/config.test.ts— its sole consumer, only existed to test the barrel itself