Skip to content

Remove dead re-export barrel src/types/config.ts#3144

Merged
lpcox merged 3 commits into
mainfrom
copilot/export-audit-remove-unused-re-export
May 14, 2026
Merged

Remove dead re-export barrel src/types/config.ts#3144
lpcox merged 3 commits into
mainfrom
copilot/export-audit-remove-unused-re-export

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

src/types/config.ts was a "backward-compatible re-exports" barrel with no production importers — every consumer already resolves to src/types/index.ts, which is a strict superset. The file posed a silent divergence risk: new types added to index.ts required a separate decision to mirror in config.ts.

Changes

  • Deleted src/types/config.ts — dead re-export barrel, never imported by production code
  • Deleted src/types/config.test.ts — its sole consumer, only existed to test the barrel itself

Copilot AI changed the title [WIP] Remove unused re-export barrel from src/types/config.ts Remove dead re-export barrel src/types/config.ts May 14, 2026
Copilot AI requested a review from lpcox May 14, 2026 13:40
Copilot finished work on behalf of lpcox May 14, 2026 13:40
@lpcox lpcox marked this pull request as ready for review May 14, 2026 13:40
@lpcox lpcox requested a review from Mossaka as a code owner May 14, 2026 13:40
Copilot AI review requested due to automatic review settings May 14, 2026 13:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy src/types/config.ts re-export barrel and its dedicated test. The intended cleanup is small, but the deletion currently leaves an internal production import unresolved.

Changes:

  • Deleted the backward-compatible src/types/config.ts barrel.
  • Deleted the test that only validated that barrel’s re-exports.
Show a summary per file
File Description
src/types/config.ts Removes the legacy config/type re-export barrel.
src/types/config.test.ts Removes tests that only exercised the deleted barrel.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

src/types/config.ts:1

  • Deleting this barrel breaks the existing production type import in src/types/docker.ts (import type { UpstreamProxyConfig } from './config';). Because tsconfig.json includes src/**/*, the build will fail with a missing module unless that importer is updated (for example to ./upstream-proxy) before removing this file.
  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lpcox
Copy link
Copy Markdown
Collaborator

lpcox commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot fix the failing ci check https://github.com/github/gh-aw-firewall/actions/runs/25863264750/job/75998726653?pr=3144

src/types/docker.ts had a stray import type { UpstreamProxyConfig } from './config' that I missed. Fixed in the latest commit — the import now points directly to ./upstream-proxy, and npm run build passes cleanly.

Copilot finished work on behalf of lpcox May 14, 2026 13:52
@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Status
GitHub MCP connectivity ❌ (401 Bad credentials)
GitHub.com HTTP connectivity ⚠️ (template vars not expanded)
File write/read (smoke-test-copilot-25863887329.txt)

Overall: FAIL — GitHub MCP authentication unavailable in this environment.

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • ❌ GitHub API: HTTP 401 (authentication failed)
  • ✅ Playwright: GitHub.com navigation confirmed (title contains "GitHub")
  • ✅ File verify: Smoke test file present with expected content

Result: 2/3 PASS — API test blocked by auth issue

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ❌ 401 — GitHub MCP not authenticated in this environment
GitHub.com HTTP connectivity ⚠️ Pre-step data not available (template vars unresolved)
File write/read ⚠️ Pre-step data not available (template vars unresolved)
BYOK inference (api-proxy → api.githubcopilot.com) ✅ Agent received and responded to prompt

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: FAIL — GitHub MCP returned 401 and pre-step outputs were not injected into the prompt.

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Codex: FAIL
PRs: fix: skip node --version check under QEMU emulation in agent Dockerfile; fix: remove unused public exports and normalize test-only access
✅ Merged PR review; ❌ safeinputs-gh; ✅ Playwright title; ❌ Tavily search
✅ File write/read; ⚪ Discussion skipped; ✅ npm ci && npm run build
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • GitHub MCP Testing: ❌ (mcpscripts command not found)
  • Connectivity: ❌ (HTTP 000 - SSL connect error)
  • File Writing: ✅
  • Bash Tool: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Smoke Test Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3
Node.js v24.14.1 v20.20.2
Go go1.22.12 go1.22.12

Result: FAILED — Python and Node.js versions differ between host and chroot. Go matches.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color ok ✅ PASS
Go env ok ✅ PASS
Go uuid ok ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3144 · ● 21.6M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results — FAIL

Check Result
Redis PING ❌ Timeout (no response)
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Not attempted (pg_isready failed)

host.docker.internal is not reachable from this runner environment — service containers appear inaccessible.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit e04255b into main May 14, 2026
64 of 68 checks passed
@lpcox lpcox deleted the copilot/export-audit-remove-unused-re-export branch May 14, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Dead re-export barrel src/types/config.ts is never imported by production code

3 participants